Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make volume slider responsive according to player size #1356

Merged
merged 13 commits into from
Oct 4, 2022
Merged

feat: make volume slider responsive according to player size #1356

merged 13 commits into from
Oct 4, 2022

Commits on Oct 1, 2022

  1. feat: make volume slider responsive according to player size

    @Pompette
    Pompette committed Oct 1, 2022
    Configuration menu
    Copy the full SHA
    aae64d5 View commit details
    Browse the repository at this point in the history

  2. feat: add extra space for better ui

    @Pompette
    Pompette committed Oct 1, 2022
    Configuration menu
    Copy the full SHA
    de9fdf1 View commit details
    Browse the repository at this point in the history

  3. fix: if config width change, reinject class either

    @Pompette
    Pompette committed Oct 1, 2022
    Configuration menu
    Copy the full SHA
    9c178b6 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2022

  1. feat: make volume responsive according to available space 

    Time label now cannot overflow to other component, if it goes above the space available overflow is show as ellipsis.
Creation of custom hook that handle the resize of component.
    @Pompette
    Pompette committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    cdda177 View commit details
    Browse the repository at this point in the history

  2. fix: lint error, put padding as variable

    @Pompette
    Pompette committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    9508670 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2022

  1. use playerwidth instead of canvas width

    @JonnyBurger
    JonnyBurger committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    421bf57 View commit details
    Browse the repository at this point in the history

  2. memoize styles

    @JonnyBurger
    JonnyBurger committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    2b1f7c7 View commit details
    Browse the repository at this point in the history

  3. use a vertical slider

    @JonnyBurger
    JonnyBurger committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    c71e96f View commit details
    Browse the repository at this point in the history

  4. get vertical slider working in pure JS

    @JonnyBurger
    JonnyBurger committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    56beebf View commit details
    Browse the repository at this point in the history

  5. eliminate requirement to inject CSS

    @JonnyBurger
    JonnyBurger committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    08b52db View commit details
    Browse the repository at this point in the history

  6. remove removeCss function

    @JonnyBurger
    JonnyBurger committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    baf26dd View commit details
    Browse the repository at this point in the history

  7. memoize timelabel

    @JonnyBurger
    JonnyBurger committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    1c01ed3 View commit details
    Browse the repository at this point in the history

  8. put widths into variables

    @JonnyBurger
    JonnyBurger committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    81336d0 View commit details
    Browse the repository at this point in the history