New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
derive codec from file extension for remotion lambda
#1357
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@JonnyBurger how can I make this test pass? |
@uragirii The output for this test is pretty bad, I'll try to at least fix the logging tomorrow so it will give a proper error message! |
@uragirii I have pushed some better error handling, now it's much clearer why the test fails! |
@JonnyBurger seems like tests are wrong! haha! If you want i can fix the tests. Also, the pr should be ready to be reviewed ;) |
🥸 |
Fixed, let's see! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did some refactors myself since there were already quite a few bugs before and there are many factors for deciding codec and image format!
Nonetheless, excellent work! For statistics, how long do you estimate did it take for you to work on this PR?
Thanks for merging, and fixes my errors. The amount of time ig is 1:30-2hrs |
Fixes #1248.
npx remotion lambda
derives the codec from the file extension provided by the userIssueHunt Summary
Referenced issues
This pull request has been submitted to:
npx remotion lambda render
does not derive the codec from the file extension