Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

derive codec from file extension for remotion lambda #1357

Merged
merged 21 commits into from Oct 7, 2022
Merged

derive codec from file extension for remotion lambda #1357

merged 21 commits into from Oct 7, 2022

Conversation

uragirii
Copy link
Contributor

@uragirii uragirii commented Oct 1, 2022

Fixes #1248. npx remotion lambda derives the codec from the file extension provided by the user


IssueHunt Summary

Referenced issues

This pull request has been submitted to:


@vercel
Copy link

vercel bot commented Oct 1, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
remotion ✅ Ready (Inspect) Visit Preview Oct 7, 2022 at 0:06AM (UTC)

@JonnyBurger
Copy link
Member

Thanks a lot @uragirii! 🙌

This is an improvement that I am willing to merge, to be eligible for the $100 bounty though, the acceptance criteria I posted in #1248 should also pass.

@uragirii
Copy link
Contributor Author

uragirii commented Oct 4, 2022

@JonnyBurger how can I make this test pass?
Screenshot 2022-10-04 at 11 42 52 PM

@JonnyBurger
Copy link
Member

@uragirii The output for this test is pretty bad, I'll try to at least fix the logging tomorrow so it will give a proper error message!

@JonnyBurger
Copy link
Member

@uragirii I have pushed some better error handling, now it's much clearer why the test fails!

image

@uragirii
Copy link
Contributor Author

uragirii commented Oct 6, 2022

@JonnyBurger seems like tests are wrong! haha!
In transparent-webm.test.ts the outName is "out.mp4" but should end in webm. Similar thing for gif.test.ts the outName is "out.mp4" but should end in gif.

If you want i can fix the tests. Also, the pr should be ready to be reviewed ;)

@JonnyBurger
Copy link
Member

🥸

@JonnyBurger
Copy link
Member

Fixed, let's see!

Copy link
Member

@JonnyBurger JonnyBurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some refactors myself since there were already quite a few bugs before and there are many factors for deciding codec and image format!

Nonetheless, excellent work! For statistics, how long do you estimate did it take for you to work on this PR?

@JonnyBurger JonnyBurger merged commit ac3cd1a into remotion-dev:main Oct 7, 2022
@uragirii
Copy link
Contributor Author

uragirii commented Oct 7, 2022

Thanks for merging, and fixes my errors. The amount of time ig is 1:30-2hrs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npx remotion lambda render does not derive the codec from the file extension
2 participants