Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
benchmark remotion #1358
benchmark remotion #1358
Changes from 3 commits
c4aa64b
8245604
c7bcbe0
db40d04
dbcee75
45c3c34
18e4e3b
d2caf76
de73c37
73f58ad
4556f3d
276f58e
ad10ed6
cd17a7e
d6e67f4
af3705f
90d33a8
7caeaa9
883d0b0
4030f80
fad8e87
15cbf93
0f7f445
4837319
5511a1d
1e6f2be
e5c087f
51cb77f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make the user explicitly pass the path:
npx remotion benchmark src/index.tsx ...
for now.We will tackle this in another issue where this can be omitted for all commands.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we don't need to download (or clone) benchmark repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it can be a entry point, URL, or filepath to a bundle (Through #1048 in the future)