feat(render-still): handle negativ frame index #1364

Slashgear · 2022-10-03T17:39:07Z

Why

Close #1283

Take negative integers in renderStill(),
renderStillOnLambda(),
npx remotion still
npx remotion lambda still
treat them as frames from the back: -1 means last frame, -2 means second to last frame etc.
Keep up the strict validation, e.g. -200 should not be possible if the duration is only 100 frames.
Document the feature in the documentation pages of the APIs and commands that accept this option.

IssueHunt Summary

This pull request has been submitted to:

vercel · 2022-10-03T17:39:13Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
remotion	✅ Ready (Inspect)	Visit Preview	Oct 4, 2022 at 8:12AM (UTC)

JonnyBurger · 2022-10-03T19:15:57Z

Sick! Looks good on first sight, will properly review it tomorrow!

JonnyBurger · 2022-10-04T08:13:36Z

LGTM! Thanks a lot 🙌

feat(render-still): handle negativ frame index

6d81a3c

Close remotion-dev#1283

vercel bot deployed to Preview – remotion October 3, 2022 17:41 View deployment

JonnyBurger added 3 commits October 4, 2022 09:43

Delete pts-framermp4withoutfileextension.mp4

b2fa388

simplify documentation

cd6f091

convertToPositiveFrameIndex helper function

381943f

vercel bot had a problem deploying to Preview – remotion October 4, 2022 08:04 Failure

use convertToPositiveFrameIndex

9089316

vercel bot deployed to Preview – remotion October 4, 2022 08:12 View deployment

JonnyBurger enabled auto-merge October 4, 2022 08:12

JonnyBurger merged commit 5460153 into remotion-dev:main Oct 4, 2022