Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: warn apple silicon rosetta. Closes #1362 #1373

Merged
merged 9 commits into from Oct 6, 2022
Merged

feat: warn apple silicon rosetta. Closes #1362 #1373

merged 9 commits into from Oct 6, 2022

Conversation

danmana
Copy link
Contributor

@danmana danmana commented Oct 5, 2022 •
edited by issuehunt-oss bot

Closes #1362

How to test

cd packages/renderer
npm run build
nvm use 14
node ./dist/index.js

Useful hints for installing multiple versions of node (intel and arm side by side)
https://gist.github.com/LeZuse/bf838718ff2689c5fc035c5a6825a11c

IssueHunt Summary

Referenced issues

This pull request has been submitted to:

@vercel
Copy link

vercel bot commented Oct 5, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
remotion ✅ Ready (Inspect) Visit Preview Oct 6, 2022 at 7:55AM (UTC)

@danmana danmana changed the title Feat/warn apple silicon rosetta. Closes #1362 feat: warn apple silicon rosetta. Closes #1362 Oct 5, 2022
@JonnyBurger
Copy link
Member

Perfect! Thanks a lot! 🙌

@JonnyBurger JonnyBurger merged commit 8c23211 into remotion-dev:main Oct 6, 2022
@danmana
Copy link
Contributor Author

danmana commented Oct 6, 2022

Thanks, it was my first time working with Remotion.
It looks like a cool project, and it was easy to work on, the issue description was well written and clear.

@JonnyBurger
Copy link
Member

@danmana Thanks a lot, very glad to hear that! 🙌
For statistics: How long do you estimate you spent on this issue?

@danmana danmana deleted the feat/warn-apple-silicon-rosetta branch October 6, 2022 18:51
@danmana
Copy link
Contributor Author

danmana commented Oct 6, 2022

@JonnyBurger I haven't kept track exactly, and I worked in a few sessions when I had some spare time ... overall maybe 2-3h

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue a warning if using an Apple Silicon Mac under Rosetta
2 participants
@danmana @JonnyBurger