Report slowest frames

[uragirii]

Fixes #1344

renderMedia returns array of 10 slowest frames with frame indexes for user to optimise them.

Tasks:

• Report in cli in verbose mode
• Log slowest frames in lambda
• Update docs
• CI build pass (or fix tests)?

---

IssueHunt Summary

Referenced issues

This pull request has been submitted to:

• #1344: Report slowest frames of renderMedia()

---

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
remotion	✅ Ready (Inspect)	Visit Preview	Oct 10, 2022 at 6:33PM (UTC)

[uragirii]

@JonnyBurger idk if its a configuration error? or older node version

[JonnyBurger]

@uragirii Array.at cannot be used because it is not supported in Node.JS. We need to use normal array[i] notation for now

[uragirii]

@JonnyBurger should be ready for review

[JonnyBurger]

Thanks a lot! Looks mostly good!
I realized that renderMedia() already has a return type and this would be a breaking change.

Therefore I had to change the API to be a callback in order to not break the function signature. We can refactor this in Remotion v4.

Only problem I see:
When rendering using pnpm exec remotion render src/index.tsx react-svg --log=verbose in packages/example, in about 20-30% of the cases, the frames are out of order:

This is the last blocker before I can merge this.

[uragirii]

@JonnyBurger now it should be fixed. Also, there is a small "bug", the first concurrent number of frames would always be in the slowest frames as they also include the time of opening chrome tabs. We could get "actual" concurrency value and omit them, what do you think?

[JonnyBurger]

@uragirii Thanks!

I have noticed another bug: The timing is since the last frame was rendered, but since multiple frames are rendered in parallel, that does not reflect the time it has taken to render a frame. Fixed now!

Regarding the first frame of a tab being slower, I think let's embrace it! It's useful to see the initialization time. This looks insightful to me:

[JonnyBurger]

And with that, fully happy 🎉

Thanks a lot for building this feature! How long did you approximately spend on this PR?

[uragirii]

The timing is since the last frame was rendered, but since multiple frames are rendered in parallel, that does not reflect the time it has taken to render a frame.

Ahh didn't thought of that! Great!

How long did you approximately spend on this PR?

1-1.5 hour