Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icons to navigation bar on website #3873

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

MehmetAdemi
Copy link
Member

@JonnyBurger, what do you think?
Screenshot 2024-05-15 at 12 17 17
Screenshot 2024-05-15 at 12 17 48

@MehmetAdemi MehmetAdemi self-assigned this May 15, 2024
Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bugs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 10:44am
remotion ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 10:44am

@JonnyBurger
Copy link
Member

I like it! Is it ready to merge?

@MehmetAdemi
Copy link
Member Author

MehmetAdemi commented May 15, 2024

The functionality of the hovering effect works for dark mode as well as for light mode. It's ready to merge. I'll leave the merging to you.

@MehmetAdemi MehmetAdemi marked this pull request as ready for review May 15, 2024 13:56
@JonnyBurger
Copy link
Member

Nice 🙌

@JonnyBurger JonnyBurger merged commit 39e12cd into main May 15, 2024
13 checks passed
@JonnyBurger JonnyBurger deleted the add-icons-to-NavBar branch May 15, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants