Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes issue #1476 after introduced again by version 2.0.2 #1661

Closed
wants to merge 1 commit into from

Conversation

marcelkottmann
Copy link
Contributor

Hey @remy , seems like issue #1476 was introduced again by version 2.0.2. Please look at my new comment in #1476 (comment)

We have to wait for all subprocess to shutdown before killing the main process. Killing the main process has the side effect of emitting the exit-event, which in turn starts the program again (too early) before the child processes have been terminated.

I updated the test repository to reproduce this error with nodemon@2.0.2 and to test the fix: https://github.com/marcelkottmann/test-nodemon-issue-1476

@hphvac
Copy link

hphvac commented Jan 19, 2020

Would be nice, this problem still exists for me

@remy
Copy link
Owner

remy commented Jan 22, 2020

The change in the order which the processes are stopped was intentional. Specifically this change: 47dfb8b

Can you check that your change still allows the origin issue to be solved? #1638 (I appreciate this was from a refactor with the release of 2.0.1 that simplified your original code - which was also fixed bugs on linux platforms)

@stale
Copy link

stale bot commented Feb 5, 2020

This issue has been automatically marked as idle and stale because it hasn't had any recent activity. It will be automtically closed if no further activity occurs. If you think this is wrong, or the problem still persists, just pop a reply in the comments and @remy will (try!) to follow up.
Thank you for contributing <3

@stale stale bot added the stale no activity for 2 weeks label Feb 5, 2020
@hphvac
Copy link

hphvac commented Feb 5, 2020

I am currently running 2.0.2. I believe that the issue you referenced doesn't apply to me.

@stale stale bot removed the stale no activity for 2 weeks label Feb 5, 2020
@stale
Copy link

stale bot commented Feb 20, 2020

This issue has been automatically marked as idle and stale because it hasn't had any recent activity. It will be automtically closed if no further activity occurs. If you think this is wrong, or the problem still persists, just pop a reply in the comments and @remy will (try!) to follow up.
Thank you for contributing <3

@stale stale bot added the stale no activity for 2 weeks label Feb 20, 2020
@stale stale bot closed this Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale no activity for 2 weeks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants