Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(deps): remove update notifier #2015

Closed
wants to merge 1 commit into from

Conversation

jimmywarting
Copy link

@jimmywarting jimmywarting commented Jun 2, 2022

This will remove 76 sup dependencies some of us do not want to have to download and risk getting any security issues along with it.
This will drastically lower the time/bandwidth to install the nodemon package

the way to notify user about outdated packages should be done via npm deprecate instead to let user know that they are installing a outdated version instead

fix #1961
fix #1995

@netlify
Copy link

netlify bot commented Jun 2, 2022

Deploy Preview for nodemon ready!

Name Link
🔨 Latest commit 47e8d1c
🔍 Latest deploy log https://app.netlify.com/sites/nodemon/deploys/6298db13e6f3a9000911b01a
😎 Deploy Preview https://deploy-preview-2015--nodemon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jimmywarting jimmywarting changed the title fix: remove update notifier core(deps): remove update notifier Jun 2, 2022
@remy
Copy link
Owner

remy commented Jun 7, 2022

As discussed in tickets, flat out removing the update logic isn't a path I intend to take. I'm keen to remove update-notifier but whilst replacing it with nodemon's own simpler system.

@remy remy closed this Jun 7, 2022
@jimmywarting jimmywarting deleted the remove-update-notifier branch June 7, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider removing/replacing update-notifier
2 participants