Add node 20 to test matrix #2133
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nodemon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
didaquis
approved these changes
Sep 27, 2023
Abuchtela
reviewed
Oct 3, 2023
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
|
I don't think the tests are failing because of node 20 - but because something's either wrong in the test or there's a regression somewhere… I'm trying to have a look but don't have a lot of time (on the computer) atm - but if no one else does, I will do and I will get node 20 in the matrix. |
|
How would you feel about just testing only the latest 3 versions? 16, 18, 20? and setting minium node version to it as well in package.json |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.