Skip to content

Commit

Permalink
feat(platform/gitea): use automergeStrategy in createPr (#26448)
Browse files Browse the repository at this point in the history
  • Loading branch information
joegoldman2 committed Dec 28, 2023
1 parent 53e1ca6 commit 0710a35
Show file tree
Hide file tree
Showing 2 changed files with 78 additions and 2 deletions.
75 changes: 75 additions & 0 deletions lib/modules/platform/gitea/index.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1217,6 +1217,81 @@ describe('modules/platform/gitea/index', () => {
});
expect(helper.mergePR).not.toHaveBeenCalled();
});

it('should create PR with repository merge method when automergeStrategy is auto', async () => {
helper.createPR.mockResolvedValueOnce(mockNewPR);
await initFakePlatform('1.17.0');
await initFakeRepo();
await gitea.createPr({
sourceBranch: mockNewPR.head.label,
targetBranch: 'master',
prTitle: mockNewPR.title,
prBody: mockNewPR.body,
platformOptions: {
automergeStrategy: 'auto',
usePlatformAutomerge: true,
},
});

expect(helper.createPR).toHaveBeenCalledTimes(1);
expect(helper.createPR).toHaveBeenCalledWith(mockRepo.full_name, {
base: mockNewPR.base.ref,
head: mockNewPR.head.label,
title: mockNewPR.title,
body: mockNewPR.body,
labels: [],
});
expect(helper.mergePR).toHaveBeenCalledWith(
mockRepo.full_name,
mockNewPR.number,
{
Do: 'rebase',
merge_when_checks_succeed: true,
},
);
});

it.each`
automergeStrategy | prMergeStrategy
${'fast-forward'} | ${'rebase'}
${'merge-commit'} | ${'merge'}
${'rebase'} | ${'rebase-merge'}
${'squash'} | ${'squash'}
`(
'should create PR with mergeStrategy $prMergeStrategy',
async ({ automergeStrategy, prMergeStrategy }) => {
helper.createPR.mockResolvedValueOnce(mockNewPR);
await initFakePlatform('1.17.0');
await initFakeRepo();
await gitea.createPr({
sourceBranch: mockNewPR.head.label,
targetBranch: 'master',
prTitle: mockNewPR.title,
prBody: mockNewPR.body,
platformOptions: {
automergeStrategy,
usePlatformAutomerge: true,
},
});

expect(helper.createPR).toHaveBeenCalledTimes(1);
expect(helper.createPR).toHaveBeenCalledWith(mockRepo.full_name, {
base: mockNewPR.base.ref,
head: mockNewPR.head.label,
title: mockNewPR.title,
body: mockNewPR.body,
labels: [],
});
expect(helper.mergePR).toHaveBeenCalledWith(
mockRepo.full_name,
mockNewPR.number,
{
Do: prMergeStrategy,
merge_when_checks_succeed: true,
},
);
},
);
});

describe('updatePr', () => {
Expand Down
5 changes: 3 additions & 2 deletions lib/modules/platform/gitea/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -544,8 +544,9 @@ const platform: Platform = {
if (semver.gte(defaults.version, '1.17.0')) {
try {
await helper.mergePR(config.repository, gpr.number, {
// TODO: pass strategy (#16884)
Do: config.mergeMethod,
Do:
getMergeMethod(platformOptions?.automergeStrategy) ??
config.mergeMethod,
merge_when_checks_succeed: true,
});

Expand Down

0 comments on commit 0710a35

Please sign in to comment.