Skip to content

Commit

Permalink
feat(config): Add @babel/eslint-parser to ESLint packages Presets (#2…
Browse files Browse the repository at this point in the history
  • Loading branch information
yusato committed Mar 19, 2024
1 parent 5d4f190 commit 0e16efa
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 5 deletions.
3 changes: 3 additions & 0 deletions lib/config/presets/__snapshots__/index.spec.ts.snap
Expand Up @@ -119,6 +119,7 @@ exports[`config/presets/index resolvePreset resolves eslint 1`] = `
"matchPackageNames": [
"@types/eslint",
"babel-eslint",
"@babel/eslint-parser",
],
"matchPackagePrefixes": [
"@typescript-eslint/",
Expand All @@ -135,6 +136,7 @@ exports[`config/presets/index resolvePreset resolves linters 1`] = `
"matchPackageNames": [
"@types/eslint",
"babel-eslint",
"@babel/eslint-parser",
"friendsofphp/php-cs-fixer",
"squizlabs/php_codesniffer",
"symplify/easy-coding-standard",
Expand Down Expand Up @@ -169,6 +171,7 @@ exports[`config/presets/index resolvePreset resolves nested groups 1`] = `
"matchPackageNames": [
"@types/eslint",
"babel-eslint",
"@babel/eslint-parser",
"friendsofphp/php-cs-fixer",
"squizlabs/php_codesniffer",
"symplify/easy-coding-standard",
Expand Down
16 changes: 12 additions & 4 deletions lib/config/presets/index.spec.ts
Expand Up @@ -233,7 +233,11 @@ describe('config/presets/index', () => {
config.extends = ['packages:eslint', 'packages:stylelint'];
const res = await presets.resolveConfigPresets(config);
expect(res).toEqual({
matchPackageNames: ['@types/eslint', 'babel-eslint'],
matchPackageNames: [
'@types/eslint',
'babel-eslint',
'@babel/eslint-parser',
],
matchPackagePrefixes: ['@typescript-eslint/', 'eslint', 'stylelint'],
});
});
Expand All @@ -250,7 +254,11 @@ describe('config/presets/index', () => {
packageRules: [
{
groupName: 'eslint',
matchPackageNames: ['@types/eslint', 'babel-eslint'],
matchPackageNames: [
'@types/eslint',
'babel-eslint',
'@babel/eslint-parser',
],
matchPackagePrefixes: ['@typescript-eslint/', 'eslint'],
},
],
Expand All @@ -268,7 +276,7 @@ describe('config/presets/index', () => {
config.extends = ['packages:linters'];
const res = await presets.resolveConfigPresets(config);
expect(res).toMatchSnapshot();
expect(res.matchPackageNames).toHaveLength(9);
expect(res.matchPackageNames).toHaveLength(10);
expect(res.matchPackagePatterns).toHaveLength(1);
expect(res.matchPackagePrefixes).toHaveLength(4);
});
Expand All @@ -279,7 +287,7 @@ describe('config/presets/index', () => {
expect(res).toMatchSnapshot();
const rule = res.packageRules![0];
expect(rule.automerge).toBeTrue();
expect(rule.matchPackageNames).toHaveLength(9);
expect(rule.matchPackageNames).toHaveLength(10);
expect(rule.matchPackagePatterns).toHaveLength(1);
expect(rule.matchPackagePrefixes).toHaveLength(4);
});
Expand Down
6 changes: 5 additions & 1 deletion lib/config/presets/internal/packages.ts
Expand Up @@ -22,7 +22,11 @@ export const presets: Record<string, Preset> = {
},
eslint: {
description: 'All ESLint packages.',
matchPackageNames: ['@types/eslint', 'babel-eslint'],
matchPackageNames: [
'@types/eslint',
'babel-eslint',
'@babel/eslint-parser',
],
matchPackagePrefixes: ['@typescript-eslint/', 'eslint'],
},
gatsby: {
Expand Down

0 comments on commit 0e16efa

Please sign in to comment.