fix(manager/terraform): do not return registryUrls containing undefin…

…ed (#19905)
renovatebot · Jan 18, 2023 · 1127c5e · 1127c5e
1 parent 081f002
commit 1127c5e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/modules/manager/terraform/extract.spec.ts b/lib/modules/manager/terraform/extract.spec.ts
@@ -594,7 +594,6 @@ describe('modules/manager/terraform/extract', () => {
           datasource: 'helm',
           depName: './charts/example',
           depType: 'helm_release',
-          registryUrls: [undefined],
           skipReason: 'local-chart',
         },
         {
@@ -617,7 +616,6 @@ describe('modules/manager/terraform/extract', () => {
           datasource: 'helm',
           depName: 'redis',
           depType: 'helm_release',
-          registryUrls: [undefined],
         },
       ]);
     });

diff --git a/lib/modules/manager/terraform/extractors/resources/helm-release.ts b/lib/modules/manager/terraform/extractors/resources/helm-release.ts
@@ -21,10 +21,12 @@ export class HelmReleaseExtractor extends DependencyExtractor {
         const dep: PackageDependency = {
           currentValue: helmRelease.version,
           depType: 'helm_release',
-          registryUrls: [helmRelease.repository],
           depName: helmRelease.chart,
           datasource: HelmDatasource.id,
         };
+        if (!is.nullOrUndefined(helmRelease.repository)) {
+          dep.registryUrls = [helmRelease.repository];
+        }
         if (!helmRelease.chart) {
           dep.skipReason = 'invalid-name';
         } else if (checkIfStringIsPath(helmRelease.chart)) {