fix(npm): issue with npm lerna deleting unrelated lockfile files (#17233

)
renovatebot · Aug 18, 2022 · 189e39b · 189e39b
1 parent b45ed09
commit 189e39b
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 0 deletions.
diff --git a/lib/modules/manager/npm/post-update/index.spec.ts b/lib/modules/manager/npm/post-update/index.spec.ts
@@ -78,6 +78,16 @@ describe('modules/manager/npm/post-update/index', () => {
           npmLock: 'package-lock.json',
           rangeStrategy: 'widen',
         },
+        {
+          depName: 'core-js',
+          isRemediation: true,
+          managerData: {
+            lernaJsonFile: 'lerna.json',
+          },
+          npmLock: 'randomFolder/package-lock.json',
+          lockFiles: ['randomFolder/package-lock.json'],
+          rangeStrategy: 'pin',
+        },
         {
           isLockfileUpdate: true,
           npmLock: 'package-lock.json',
@@ -209,6 +219,19 @@ describe('modules/manager/npm/post-update/index', () => {
       ]);
     });
 
+    it('works only on relevant folders', async () => {
+      git.getFile.mockResolvedValueOnce(
+        Fixtures.get('update-lockfile-massage-1/package-lock.json')
+      );
+      await expect(
+        writeExistingFiles(updateConfig, additionalFiles)
+      ).resolves.toBeUndefined();
+
+      expect(fs.writeLocalFile).toHaveBeenCalledTimes(2);
+      expect(fs.deleteLocalFile).not.toHaveBeenCalled();
+      expect(git.getFile).toHaveBeenCalledOnce();
+    });
+
     it('has no npm files', async () => {
       await expect(writeExistingFiles(baseConfig, {})).toResolve();
     });

diff --git a/lib/modules/manager/npm/post-update/index.ts b/lib/modules/manager/npm/post-update/index.ts
@@ -180,6 +180,9 @@ export async function writeExistingFiles(
           const widens: string[] = [];
           let lockFileChanged = false;
           for (const upgrade of config.upgrades) {
+            if (upgrade.lockFiles && !upgrade.lockFiles.includes(npmLock)) {
+              continue;
+            }
             if (
               upgrade.rangeStrategy === 'widen' &&
               upgrade.npmLock === npmLock