refactor(types): optional newValue (#24953)

renovatebot · Oct 2, 2023 · 1b70c42 · 1b70c42
1 parent 8a0956d
commit 1b70c42
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/lib/modules/manager/types.ts b/lib/modules/manager/types.ts
@@ -84,7 +84,7 @@ export interface LookupUpdate {
   newMajor?: number;
   newMinor?: number;
   newName?: string;
-  newValue: string;
+  newValue?: string;
   semanticCommitType?: string;
   pendingChecks?: boolean;
   pendingVersions?: string[];

diff --git a/lib/workers/repository/process/lookup/generate.ts b/lib/workers/repository/process/lookup/generate.ts
@@ -66,7 +66,7 @@ export async function generateUpdate(
       update.newValue = currentValue;
     }
   } else {
-    update.newValue = currentValue!;
+    update.newValue = currentValue;
   }
   update.newMajor = versioning.getMajor(newVersion)!;
   update.newMinor = versioning.getMinor(newVersion)!;

diff --git a/lib/workers/repository/process/lookup/index.ts b/lib/workers/repository/process/lookup/index.ts
@@ -381,10 +381,9 @@ export async function lookupUpdates(
           }
           res.isSingleVersion = true;
         }
-        res.isSingleVersion =
-          !!res.isSingleVersion ||
-          !!versioning.isSingleVersion(update.newValue);
-
+        res.isSingleVersion ??=
+          is.string(update.newValue) &&
+          versioning.isSingleVersion(update.newValue);
         res.updates.push(update);
       }
     } else if (compareValue) {
@@ -455,7 +454,7 @@ export async function lookupUpdates(
       ) {
         for (const update of res.updates) {
           logger.debug({ update });
-          if (is.string(config.currentValue)) {
+          if (is.string(config.currentValue) && is.string(update.newValue)) {
             update.newValue = config.currentValue.replace(
               compareValue,
               update.newValue