refactor(preset): update regexManagers: to customManagers: (#28979)

renovatebot · May 13, 2024 · 2bec323 · 2bec323
1 parent b5908cf
commit 2bec323
Show file tree

Hide file tree

Showing 8 changed files with 26 additions and 7 deletions.
diff --git a/docs/usage/.pages b/docs/usage/.pages
@@ -32,6 +32,7 @@ nav:
       - 'Noise Reduction': 'noise-reduction.md'
       - 'Upgrade best practices': 'upgrade-best-practices.md'
   - Included Presets:
+      - 'Custom Manager Presets': 'presets-customManagers.md'
       - 'Default Presets': 'presets-default.md'
       - 'Docker Presets': 'presets-docker.md'
       - 'Full Config Presets': 'presets-config.md'
@@ -41,7 +42,6 @@ nav:
       - 'npm Presets': 'presets-npm.md'
       - 'Package Presets': 'presets-packages.md'
       - 'Preview Presets': 'presets-preview.md'
-      - 'Regex Manager Presets': 'presets-regexManagers.md'
       - 'Replacement Presets': 'presets-replacements.md'
       - 'Schedule Presets': 'presets-schedule.md'
       - 'Security Presets': 'presets-security.md'

diff --git a/docs/usage/configuration-options.md b/docs/usage/configuration-options.md
@@ -703,7 +703,7 @@ For template fields, use the triple brace `{{{ }}}` notation to avoid Handlebars
 
 <!-- prettier-ignore -->
 !!! tip
-    Look at our [Regex Manager Presets](./presets-regexManagers.md), they may have what you need.
+    Look at our [Custom Manager Presets](./presets-customManagers.md), they may have what you need.
 
 ### customType
 

diff --git a/lib/config/presets/common.ts b/lib/config/presets/common.ts
@@ -31,6 +31,17 @@ export const removedPresets: Record<string, string | null> = {
   'github>whitesource/merge-confidence:beta': 'mergeConfidence:all-badges',
   'replacements:messageFormat-{{package}}-to-@messageformat/{{package}}':
     'replacements:messageFormat-to-scoped',
+  'regexManagers:biomeVersions': 'customManagers:biomeVersions',
+  'regexManagers:bitbucketPipelinesVersions':
+    'customManagers:bitbucketPipelinesVersions',
+  'regexManagers:dockerfileVersions': 'customManagers:dockerfileVersions',
+  'regexManagers:githubActionsVersions': 'customManagers:githubActionsVersions',
+  'regexManagers:gitlabPipelineVersions':
+    'customManagers:gitlabPipelineVersions',
+  'regexManagers:helmChartYamlAppVersions':
+    'customManagers:helmChartYamlAppVersions',
+  'regexManagers:mavenPropertyVersions': 'customManagers:mavenPropertyVersions',
+  'regexManagers:tfvarsVersions': 'customManagers:tfvarsVersions',
 };
 
 const renamedMonorepos: Record<string, string> = {

diff --git a/lib/config/presets/index.spec.ts b/lib/config/presets/index.spec.ts
@@ -1062,6 +1062,14 @@ describe('config/presets/index', () => {
       `);
     });
 
+    it('handles renamed regexManagers presets', async () => {
+      const res = await presets.getPreset(
+        'regexManagers:dockerfileVersions',
+        {},
+      );
+      expect(res.customManagers).toHaveLength(1);
+    });
+
     it('gets linters', async () => {
       const res = await presets.getPreset('packages:linters', {});
       expect(res).toMatchSnapshot();

diff --git a/lib/config/presets/index.ts b/lib/config/presets/index.ts
@@ -148,6 +148,7 @@ export function parsePreset(input: string): ParsedPreset {
   const presetsPackages = [
     'compatibility',
     'config',
+    'customManagers',
     'default',
     'docker',
     'group',
@@ -157,7 +158,6 @@ export function parsePreset(input: string): ParsedPreset {
     'npm',
     'packages',
     'preview',
-    'regexManagers',
     'replacements',
     'schedule',
     'security',

diff --git a/...g/presets/internal/regex-managers.spec.ts → .../presets/internal/custom-managers.spec.ts b/...g/presets/internal/regex-managers.spec.ts → .../presets/internal/custom-managers.spec.ts
@@ -1,9 +1,9 @@
 import { codeBlock } from 'common-tags';
 import { regexMatches } from '../../../../test/util';
 import { extractPackageFile } from '../../../modules/manager/custom/regex';
-import { presets } from './regex-managers';
+import { presets } from './custom-managers';
 
-describe('config/presets/internal/regex-managers', () => {
+describe('config/presets/internal/custom-managers', () => {
   describe('Update `$schema` version in biome.json', () => {
     const customManager = presets['biomeVersions'].customManagers?.[0];
 

diff --git a/...config/presets/internal/regex-managers.ts → ...onfig/presets/internal/custom-managers.ts b/...config/presets/internal/regex-managers.ts → ...onfig/presets/internal/custom-managers.ts
diff --git a/lib/config/presets/internal/index.ts b/lib/config/presets/internal/index.ts
@@ -1,5 +1,6 @@
 import type { Preset, PresetConfig } from '../types';
 import * as configPreset from './config';
+import * as customManagersPreset from './custom-managers';
 import * as defaultPreset from './default';
 import * as dockerPreset from './docker';
 import * as groupPreset from './group';
@@ -9,7 +10,6 @@ import * as monorepoPreset from './monorepo';
 import * as npm from './npm';
 import * as packagesPreset from './packages';
 import * as previewPreset from './preview';
-import * as regexManagersPreset from './regex-managers';
 import * as replacements from './replacements';
 import * as schedulePreset from './schedule';
 import * as securityPreset from './security';
@@ -19,6 +19,7 @@ import * as workaroundsPreset from './workarounds';
 
 export const groups: Record<string, Record<string, Preset>> = {
   config: configPreset.presets,
+  customManagers: customManagersPreset.presets,
   default: defaultPreset.presets,
   docker: dockerPreset.presets,
   group: groupPreset.presets,
@@ -28,7 +29,6 @@ export const groups: Record<string, Record<string, Preset>> = {
   npm: npm.presets,
   packages: packagesPreset.presets,
   preview: previewPreset.presets,
-  regexManagers: regexManagersPreset.presets,
   replacements: replacements.presets,
   schedule: schedulePreset.presets,
   security: securityPreset.presets,