fix: Revert "feat: implement custom.<customMgrName> syntax for `mat…

…chManagers` (#24112) (#24125)
renovatebot · Aug 28, 2023 · 30359ac · 30359ac
1 parent 0578cdc
commit 30359ac
Show file tree

Hide file tree

Showing 6 changed files with 2 additions and 63 deletions.
diff --git a/lib/config/migrations/custom/match-managers-migration.spec.ts b/lib/config/migrations/custom/match-managers-migration.spec.ts
diff --git a/lib/config/migrations/custom/match-managers-migration.ts b/lib/config/migrations/custom/match-managers-migration.ts
diff --git a/lib/config/validation-helpers/managers.spec.ts b/lib/config/validation-helpers/managers.spec.ts
@@ -3,7 +3,7 @@ import { check } from './managers';
 describe('config/validation-helpers/managers', () => {
   it('should have no errors', () => {
     const res = check({
-      resolvedRule: { matchManagers: ['npm', 'regex', 'custom.regex'] },
+      resolvedRule: { matchManagers: ['npm', 'regex'] },
       currentPath: '',
     });
     expect(res).toEqual([]);

diff --git a/lib/config/validation-helpers/managers.ts b/lib/config/validation-helpers/managers.ts
@@ -13,8 +13,7 @@ export function check({
   if (Array.isArray(resolvedRule.matchManagers)) {
     if (
       resolvedRule.matchManagers.find(
-        (confManager) =>
-          !allManagersList.includes(confManager.replace('custom.', ''))
+        (confManager) => !allManagersList.includes(confManager)
       )
     ) {
       managersErrMessage = `${currentPath}:

diff --git a/lib/util/package-rules/managers.spec.ts b/lib/util/package-rules/managers.spec.ts
@@ -47,17 +47,5 @@ describe('util/package-rules/managers', () => {
       );
       expect(result).toBeFalse();
     });
-
-    it('should match custom managers', () => {
-      const result = managersMatcher.matches(
-        {
-          manager: 'regex',
-        },
-        {
-          matchManagers: ['custom.regex'],
-        }
-      );
-      expect(result).toBeTrue();
-    });
   });
 });
diff --git a/lib/util/package-rules/managers.ts b/lib/util/package-rules/managers.ts
@@ -1,6 +1,5 @@
 import is from '@sindresorhus/is';
 import type { PackageRule, PackageRuleInputConfig } from '../../config/types';
-import { isCustomManager } from '../../modules/manager/custom';
 import { Matcher } from './base';
 
 export class ManagersMatcher extends Matcher {
@@ -14,9 +13,6 @@ export class ManagersMatcher extends Matcher {
     if (is.undefined(manager) || !manager) {
       return false;
     }
-    if (isCustomManager(manager)) {
-      return matchManagers.includes(`custom.${manager}`);
-    }
     return matchManagers.includes(manager);
   }
 }