Skip to content

Commit

Permalink
feat(npm)!: disable rollbackPrs for npm by default (#21970)
Browse files Browse the repository at this point in the history
BREAKING CHANGE: Rollback PRs will no longer be enabled by default for npm (they are now disabled by default for all managers)
  • Loading branch information
rarkins committed Jul 4, 2023
1 parent bc693f2 commit 530f537
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 5 deletions.
5 changes: 2 additions & 3 deletions docs/usage/configuration-options.md
Original file line number Diff line number Diff line change
Expand Up @@ -3288,9 +3288,8 @@ There are times when a dependency version in use by a project gets removed from
For some registries, existing releases or even whole packages can be removed or "yanked" at any time, while for some registries only very new or unused releases can be removed.
Renovate's "rollback" feature exists to propose a downgrade to the next-highest release if the current release is no longer found in the registry.

Renovate does not create these rollback PRs by default, with one exception: npm packages get a rollback PR if needed.

You can configure the `rollbackPrs` property globally, per-language, or per-package to override the default behavior.
Renovate does not create these rollback PRs by default, so this functionality needs to be opted-into.
We recommend you do this selectively with `packageRules` and not globally.

## ruby

Expand Down
1 change: 0 additions & 1 deletion lib/config/index.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ describe('config/index', () => {
const config = getManagerConfig(parentConfig, 'npm');
expect(config).toContainEntries([
['fileMatch', ['(^|/)package\\.json$']],
['rollbackPrs', true],
]);
expect(getManagerConfig(parentConfig, 'html')).toContainEntries([
['fileMatch', ['\\.html?$']],
Expand Down
1 change: 0 additions & 1 deletion lib/modules/manager/npm/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ export const supportsLockFileMaintenance = true;

export const defaultConfig = {
fileMatch: ['(^|/)package\\.json$'],
rollbackPrs: true,
versioning: npmVersioning.id,
digest: {
prBodyDefinitions: {
Expand Down

0 comments on commit 530f537

Please sign in to comment.