fix(github): catch fork list failures gracefully (#18933)

renovatebot · Nov 16, 2022 · 9562cf4 · 9562cf4
1 parent 7adc861
commit 9562cf4
Show file tree

Hide file tree

Showing 2 changed files with 48 additions and 14 deletions.
diff --git a/lib/modules/platform/github/index.spec.ts b/lib/modules/platform/github/index.spec.ts
@@ -266,6 +266,7 @@ describe('modules/platform/github/index', () => {
     scope: httpMock.Scope,
     repository: string,
     forkExisted: boolean,
+    forkResult = 200,
     forkDefaulBranch = 'master'
   ): void {
     scope
@@ -293,7 +294,7 @@ describe('modules/platform/github/index', () => {
       // getForks
       .get(`/repos/${repository}/forks?per_page=100`)
       .reply(
-        200,
+        forkResult,
         forkExisted
           ? [
               {
@@ -335,7 +336,7 @@ describe('modules/platform/github/index', () => {
       const repo = 'some/repo';
       const branch = 'master';
       const scope = httpMock.scope(githubApiHost);
-      forkInitRepoMock(scope, repo, false, branch);
+      forkInitRepoMock(scope, repo, false, 200, branch);
       scope.get('/user').reply(404);
       await expect(
         github.initRepo({
@@ -345,6 +346,30 @@ describe('modules/platform/github/index', () => {
       ).rejects.toThrow(REPOSITORY_CANNOT_FORK);
     });
 
+    it('throws when listing forks with 404', async () => {
+      const repo = 'some/repo';
+      const scope = httpMock.scope(githubApiHost);
+      forkInitRepoMock(scope, repo, false, 404);
+      await expect(
+        github.initRepo({
+          repository: 'some/repo',
+          forkToken: 'true',
+        })
+      ).rejects.toThrow(REPOSITORY_CANNOT_FORK);
+    });
+
+    it('throws when listing forks with 500', async () => {
+      const repo = 'some/repo';
+      const scope = httpMock.scope(githubApiHost);
+      forkInitRepoMock(scope, repo, false, 500);
+      await expect(
+        github.initRepo({
+          repository: 'some/repo',
+          forkToken: 'true',
+        })
+      ).rejects.toThrow(REPOSITORY_CANNOT_FORK);
+    });
+
     it('throws when error creating fork', async () => {
       const repo = 'some/repo';
       const scope = httpMock.scope(githubApiHost);
@@ -378,7 +403,7 @@ describe('modules/platform/github/index', () => {
 
     it('detects fork default branch mismatch', async () => {
       const scope = httpMock.scope(githubApiHost);
-      forkInitRepoMock(scope, 'some/repo', true, 'not_master');
+      forkInitRepoMock(scope, 'some/repo', true, 200, 'not_master');
       scope.get('/user').reply(200, {
         login: 'forked',
       });

diff --git a/lib/modules/platform/github/index.ts b/lib/modules/platform/github/index.ts
@@ -260,17 +260,26 @@ export async function listForks(
   token: string,
   repository: string
 ): Promise<GhRestRepo[]> {
-  // Get list of existing repos
-  const url = `repos/${repository}/forks?per_page=100`;
-  const repos = (
-    await githubApi.getJson<GhRestRepo[]>(url, {
-      token,
-      paginate: true,
-      pageLimit: 100,
-    })
-  ).body;
-  logger.debug(`Found ${repos.length} forked repo(s)`);
-  return repos;
+  try {
+    // Get list of existing repos
+    const url = `repos/${repository}/forks?per_page=100`;
+    const repos = (
+      await githubApi.getJson<GhRestRepo[]>(url, {
+        token,
+        paginate: true,
+        pageLimit: 100,
+      })
+    ).body;
+    logger.debug(`Found ${repos.length} forked repo(s)`);
+    return repos;
+  } catch (err) {
+    if (err.statusCode === 404) {
+      logger.debug('Cannot list repo forks - it is likely private');
+    } else {
+      logger.debug({ err }, 'Unknown error listing repository forks');
+    }
+    throw new Error(REPOSITORY_CANNOT_FORK);
+  }
 }
 
 export async function findFork(