Optimize cache key calculation

renovatebot · May 18, 2023 · 9ec1c59 · 9ec1c59
1 parent 09581c0
commit 9ec1c59
Showing 1 changed file with 18 additions and 16 deletions.
diff --git a/lib/util/http/index.ts b/lib/util/http/index.ts
@@ -153,23 +153,25 @@ export class Http<Opts extends HttpOptions = HttpOptions> {
     options = applyAuthorization(options);
 
     // use sha512: https://www.npmjs.com/package/hasha#algorithm
-    const cacheKey = hasha([
-      'got-',
-      JSON.stringify({
-        url,
-        headers: options.headers,
-        method: options.method,
-      }),
-    ]);
+    const memCacheKey =
+      options.memCache !== false &&
+      !etagCache &&
+      (options.method === 'get' || options.method === 'head')
+        ? hasha([
+            'got-',
+            JSON.stringify({
+              url,
+              headers: options.headers,
+              method: options.method,
+            }),
+          ])
+        : null;
+
     let resPromise: Promise<HttpResponse<T>> | null = null;
 
     // Cache GET requests unless memCache=false
-    const useMemCache =
-      options.memCache !== false &&
-      (options.method === 'get' || options.method === 'head');
-
-    if (useMemCache) {
-      resPromise = memCache.get(cacheKey);
+    if (memCacheKey) {
+      resPromise = memCache.get(memCacheKey);
     }
 
     // istanbul ignore else: no cache tests
@@ -196,8 +198,8 @@ export class Http<Opts extends HttpOptions = HttpOptions> {
 
       resPromise = queuedTask();
 
-      if (useMemCache) {
-        memCache.set(cacheKey, resPromise);
+      if (memCacheKey) {
+        memCache.set(memCacheKey, resPromise);
       }
     }