fix(kustomize): validate name is a string (#24676)

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
renovatebot · Sep 27, 2023 · a6c9075 · a6c9075
1 parent 8bdcfd5
commit a6c9075
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/lib/modules/manager/kustomize/extract.spec.ts b/lib/modules/manager/kustomize/extract.spec.ts
@@ -186,6 +186,15 @@ describe('modules/manager/kustomize/extract', () => {
       expect(pkg).toBeNull();
     });
 
+    it('should return null on invalid input', () => {
+      const pkg = extractImage({
+        // @ts-expect-error: for testing
+        name: 3,
+        newTag: '',
+      });
+      expect(pkg).toBeNull();
+    });
+
     it('should correctly extract a default image', () => {
       const sample = {
         currentDigest: undefined,

diff --git a/lib/modules/manager/kustomize/extract.ts b/lib/modules/manager/kustomize/extract.ts
@@ -67,7 +67,12 @@ export function extractImage(image: Image): PackageDependency | null {
   if (!image.name) {
     return null;
   }
-  const nameDep = splitImageParts(image.newName ?? image.name);
+  const nameToSplit = image.newName ?? image.name;
+  if (!is.string(nameToSplit)) {
+    logger.debug({ image }, 'Invalid image name');
+    return null;
+  }
+  const nameDep = splitImageParts(nameToSplit);
   const { depName } = nameDep;
   const { digest, newTag } = image;
   if (digest && newTag) {