Skip to content

Commit

Permalink
refactor: remove SkipReason.Unknown
Browse files Browse the repository at this point in the history
  • Loading branch information
rarkins committed Feb 18, 2021
1 parent 33e7e41 commit bbd78d4
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion lib/manager/buildkite/__snapshots__/extract.spec.ts.snap
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Array [
Object {
"currentValue": "v1.3.2",
"depName": "github.com/buildkite/plugin-docker-compose",
"skipReason": "unknown",
"skipReason": "invalid-dependency-specification",
},
]
`;
Expand Down
2 changes: 1 addition & 1 deletion lib/manager/buildkite/extract.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export function extractPackageFile(content: string): PackageFile | null {
{ dependency: depName },
'Something is wrong with buildkite plugin name'
);
skipReason = SkipReason.Unknown;
skipReason = SkipReason.InvalidDependencySpecification;
}
}
const dep: PackageDependency = {
Expand Down
2 changes: 1 addition & 1 deletion lib/types/skip-reason.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ export enum SkipReason {
GitPlugin = 'git-plugin',
Ignored = 'ignored',
InternalPackage = 'internal-package',
InvalidConfig = 'invalid-config',
InvalidDependencySpecification = 'invalid-dependency-specification',
InvalidName = 'invalid-name',
InvalidSha256 = 'invalid-sha256',
Expand All @@ -32,7 +33,6 @@ export enum SkipReason {
UnknownRegistry = 'unknown-registry',
UnknownVersion = 'unknown-version',
UnknownVolta = 'unknown-volta',
Unknown = 'unknown',
UnsupportedChartType = 'unsupported-chart-type',
UnsupportedRemote = 'unsupported-remote',
UnsupportedUrl = 'unsupported-url',
Expand Down
2 changes: 1 addition & 1 deletion lib/workers/repository/process/lookup/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ export async function lookupUpdates(
}
// istanbul ignore if
if (!isGetPkgReleasesConfig(config)) {
res.skipReason = SkipReason.Unknown;
res.skipReason = SkipReason.InvalidConfig;
return res;
}

Expand Down

0 comments on commit bbd78d4

Please sign in to comment.