Skip to content

Commit

Permalink
refactor: remove SkipVersion.UnsupportedValue
Browse files Browse the repository at this point in the history
  • Loading branch information
rarkins committed Feb 18, 2021
1 parent 586a83e commit c34e54c
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 7 deletions.
2 changes: 1 addition & 1 deletion lib/manager/terraform/__snapshots__/extract.spec.ts.snap
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ Object {
"skipReason": "invalid-dependency-specification",
},
Object {
"skipReason": "unsupported-value",
"skipReason": "invalid-value",
},
],
}
Expand Down
2 changes: 1 addition & 1 deletion lib/manager/terraform/resources.ts
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ export function analyseTerraformResource(
break;

default:
dep.skipReason = SkipReason.UnsupportedValue;
dep.skipReason = SkipReason.InvalidValue;
break;
}
/* eslint-enable no-param-reassign */
Expand Down
1 change: 0 additions & 1 deletion lib/types/skip-reason.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ export enum SkipReason {
UnsupportedChartType = 'unsupported-chart-type',
UnsupportedRemote = 'unsupported-remote',
UnsupportedUrl = 'unsupported-url',
UnsupportedValue = 'unsupported-value',
UnsupportedVersion = 'unsupported-version',
Unsupported = 'unsupported',
UnversionedReference = 'unversioned-reference',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1354,15 +1354,15 @@ Object {
exports[`workers/repository/process/lookup .lookupUpdates() skips undefined values 1`] = `
Object {
"skipReason": "unsupported-value",
"skipReason": "invalid-value",
"updates": Array [],
"warnings": Array [],
}
`;
exports[`workers/repository/process/lookup .lookupUpdates() skips unsupported values 1`] = `
Object {
"skipReason": "unsupported-value",
"skipReason": "invalid-value",
"updates": Array [],
"warnings": Array [],
}
Expand Down
4 changes: 2 additions & 2 deletions lib/workers/repository/process/lookup/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -401,11 +401,11 @@ export async function lookupUpdates(
res.updates.push(update);
}
} else if (!currentValue) {
res.skipReason = SkipReason.UnsupportedValue;
res.skipReason = SkipReason.InvalidValue;
} else {
logger.debug(`Dependency ${depName} has unsupported value ${currentValue}`);
if (!config.pinDigests && !config.currentDigest) {
res.skipReason = SkipReason.UnsupportedValue;
res.skipReason = SkipReason.InvalidValue;
} else {
delete res.skipReason;
}
Expand Down

0 comments on commit c34e54c

Please sign in to comment.