test: Explicit checks for some snapshots (#11365)

renovatebot · Aug 22, 2021 · d747f3e · d747f3e
1 parent a328164
commit d747f3e
Show file tree

Hide file tree

Showing 8 changed files with 268 additions and 73 deletions.
diff --git a/lib/manager/gradle-wrapper/__snapshots__/extract.spec.ts.snap b/lib/manager/gradle-wrapper/__snapshots__/extract.spec.ts.snap
@@ -1,27 +1,5 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`manager/gradle-wrapper/extract extractPackageFile() extracts all version line 1`] = `
-Array [
-  Object {
-    "currentValue": "4.10.3",
-    "datasource": "gradle-version",
-    "depName": "gradle",
-    "versioning": "gradle",
-  },
-]
-`;
-
-exports[`manager/gradle-wrapper/extract extractPackageFile() extracts bin version line 1`] = `
-Array [
-  Object {
-    "currentValue": "4.8",
-    "datasource": "gradle-version",
-    "depName": "gradle",
-    "versioning": "gradle",
-  },
-]
-`;
-
 exports[`manager/gradle-wrapper/extract extractPackageFile() extracts prerelease version line 1`] = `
 Array [
   Object {
@@ -32,14 +10,3 @@ Array [
   },
 ]
 `;
-
-exports[`manager/gradle-wrapper/extract extractPackageFile() handles whitespace 1`] = `
-Array [
-  Object {
-    "currentValue": "4.10.3",
-    "datasource": "gradle-version",
-    "depName": "gradle",
-    "versioning": "gradle",
-  },
-]
-`;
diff --git a/lib/manager/gradle-wrapper/extract.spec.ts b/lib/manager/gradle-wrapper/extract.spec.ts
@@ -17,14 +17,26 @@ describe('manager/gradle-wrapper/extract', () => {
 
     it('extracts bin version line', () => {
       const res = extractPackageFile(propertiesFile1);
-      // FIXME: explicit assert condition
-      expect(res.deps).toMatchSnapshot();
+      expect(res.deps).toEqual([
+        {
+          currentValue: '4.8',
+          datasource: 'gradle-version',
+          depName: 'gradle',
+          versioning: 'gradle',
+        },
+      ]);
     });
 
     it('extracts all version line', () => {
       const res = extractPackageFile(propertiesFile2);
-      // FIXME: explicit assert condition
-      expect(res.deps).toMatchSnapshot();
+      expect(res.deps).toEqual([
+        {
+          currentValue: '4.10.3',
+          datasource: 'gradle-version',
+          depName: 'gradle',
+          versioning: 'gradle',
+        },
+      ]);
     });
 
     it('extracts prerelease version line', () => {
@@ -40,8 +52,14 @@ describe('manager/gradle-wrapper/extract', () => {
 
     it('handles whitespace', () => {
       const res = extractPackageFile(whitespacePropertiesFile);
-      // FIXME: explicit assert condition
-      expect(res.deps).toMatchSnapshot();
+      expect(res.deps).toEqual([
+        {
+          currentValue: '4.10.3',
+          datasource: 'gradle-version',
+          depName: 'gradle',
+          versioning: 'gradle',
+        },
+      ]);
     });
   });
 });
diff --git a/lib/manager/helmv3/__snapshots__/artifacts.spec.ts.snap b/lib/manager/helmv3/__snapshots__/artifacts.spec.ts.snap
@@ -35,6 +35,17 @@ Array [
 `;
 
 exports[`manager/helmv3/artifacts returns updated Chart.lock 1`] = `
+Array [
+  Object {
+    "file": Object {
+      "contents": "New Chart.lock",
+      "name": "Chart.lock",
+    },
+  },
+]
+`;
+
+exports[`manager/helmv3/artifacts returns updated Chart.lock 2`] = `
 Array [
   Object {
     "cmd": "helm dependency update ''",
@@ -58,6 +69,17 @@ Array [
 `;
 
 exports[`manager/helmv3/artifacts returns updated Chart.lock for lockfile maintenance 1`] = `
+Array [
+  Object {
+    "file": Object {
+      "contents": "New Chart.lock",
+      "name": "Chart.lock",
+    },
+  },
+]
+`;
+
+exports[`manager/helmv3/artifacts returns updated Chart.lock for lockfile maintenance 2`] = `
 Array [
   Object {
     "cmd": "helm dependency update ''",
@@ -81,6 +103,17 @@ Array [
 `;
 
 exports[`manager/helmv3/artifacts returns updated Chart.lock with docker 1`] = `
+Array [
+  Object {
+    "file": Object {
+      "contents": "New Chart.lock",
+      "name": "Chart.lock",
+    },
+  },
+]
+`;
+
+exports[`manager/helmv3/artifacts returns updated Chart.lock with docker 2`] = `
 Array [
   Object {
     "cmd": "docker pull renovate/helm",

diff --git a/lib/manager/helmv3/artifacts.spec.ts b/lib/manager/helmv3/artifacts.spec.ts
@@ -2,7 +2,7 @@ import { exec as _exec } from 'child_process';
 import _fs from 'fs-extra';
 import { join } from 'upath';
 import { envMock, mockExecAll } from '../../../test/exec-util';
-import { git, mocked } from '../../../test/util';
+import { mocked } from '../../../test/util';
 import { setGlobalConfig } from '../../config/global';
 import type { RepoGlobalConfig } from '../../config/types';
 import * as docker from '../../util/exec/docker';
@@ -13,7 +13,6 @@ import * as helmv3 from './artifacts';
 jest.mock('fs-extra');
 jest.mock('child_process');
 jest.mock('../../util/exec/env');
-jest.mock('../../util/git');
 jest.mock('../../util/http');
 
 const fs: jest.Mocked<typeof _fs> = _fs as any;
@@ -75,53 +74,56 @@ describe('manager/helmv3/artifacts', () => {
     expect(execSnapshots).toMatchSnapshot();
   });
   it('returns updated Chart.lock', async () => {
-    git.getFile.mockResolvedValueOnce('Old Chart.lock');
+    fs.readFile.mockResolvedValueOnce('Old Chart.lock' as never);
     const execSnapshots = mockExecAll(exec);
-    fs.readFile.mockResolvedValueOnce('New Chart.lock' as any);
+    fs.readFile.mockResolvedValueOnce('New Chart.lock' as never);
     const updatedDeps = [{ depName: 'dep1' }];
-    // FIXME: explicit assert condition
     expect(
       await helmv3.updateArtifacts({
         packageFileName: 'Chart.yaml',
         updatedDeps,
         newPackageFileContent: '{}',
         config,
       })
-    ).not.toBeNull();
+    ).toMatchSnapshot([
+      { file: { contents: 'New Chart.lock', name: 'Chart.lock' } },
+    ]);
     expect(execSnapshots).toMatchSnapshot();
   });
 
   it('returns updated Chart.lock for lockfile maintenance', async () => {
-    git.getFile.mockResolvedValueOnce('Old Chart.lock');
+    fs.readFile.mockResolvedValueOnce('Old Chart.lock' as never);
     const execSnapshots = mockExecAll(exec);
-    fs.readFile.mockResolvedValueOnce('New Chart.lock' as any);
-    // FIXME: explicit assert condition
+    fs.readFile.mockResolvedValueOnce('New Chart.lock' as never);
     expect(
       await helmv3.updateArtifacts({
         packageFileName: 'Chart.yaml',
         updatedDeps: [],
         newPackageFileContent: '{}',
         config: { ...config, updateType: 'lockFileMaintenance' },
       })
-    ).not.toBeNull();
+    ).toMatchSnapshot([
+      { file: { contents: 'New Chart.lock', name: 'Chart.lock' } },
+    ]);
     expect(execSnapshots).toMatchSnapshot();
   });
 
   it('returns updated Chart.lock with docker', async () => {
     setGlobalConfig({ ...adminConfig, binarySource: 'docker' });
-    git.getFile.mockResolvedValueOnce('Old Chart.lock');
+    fs.readFile.mockResolvedValueOnce('Old Chart.lock' as never);
     const execSnapshots = mockExecAll(exec);
-    fs.readFile.mockResolvedValueOnce('New Chart.lock' as any);
+    fs.readFile.mockResolvedValueOnce('New Chart.lock' as never);
     const updatedDeps = [{ depName: 'dep1' }];
-    // FIXME: explicit assert condition
     expect(
       await helmv3.updateArtifacts({
         packageFileName: 'Chart.yaml',
         updatedDeps,
         newPackageFileContent: '{}',
         config,
       })
-    ).not.toBeNull();
+    ).toMatchSnapshot([
+      { file: { contents: 'New Chart.lock', name: 'Chart.lock' } },
+    ]);
     expect(execSnapshots).toMatchSnapshot();
   });
   it('catches errors', async () => {
@@ -130,14 +132,20 @@ describe('manager/helmv3/artifacts', () => {
       throw new Error('not found');
     });
     const updatedDeps = [{ depName: 'dep1' }];
-    // FIXME: explicit assert condition
     expect(
       await helmv3.updateArtifacts({
         packageFileName: 'Chart.yaml',
         updatedDeps,
         newPackageFileContent: '{}',
         config,
       })
-    ).toMatchSnapshot();
+    ).toMatchSnapshot([
+      {
+        artifactError: {
+          lockFile: 'Chart.lock',
+          stderr: 'not found',
+        },
+      },
+    ]);
   });
 });
diff --git a/lib/manager/leiningen/extract.spec.ts b/lib/manager/leiningen/extract.spec.ts
@@ -53,8 +53,75 @@ describe('manager/leiningen/extract', () => {
     ]);
   });
   it('extractPackageFile', () => {
-    // FIXME: explicit assert condition
-    expect(extractPackageFile(leinProjectClj)).toMatchSnapshot();
+    expect(extractPackageFile(leinProjectClj)).toMatchSnapshot({
+      deps: [
+        { depName: 'org.clojure:clojure', currentValue: '1.3.0' },
+        { depName: 'org.jclouds:jclouds', currentValue: '1.0' },
+        { depName: 'net.sf.ehcache:ehcache', currentValue: '2.3.1' },
+        { depName: 'log4j:log4j', currentValue: '1.2.15' },
+        { depName: 'net.3scale:3scale-api', currentValue: '3.0.2' },
+        { depName: 'org.lwjgl.lwjgl:lwjgl', currentValue: '2.8.5' },
+        { depName: 'org.lwjgl.lwjgl:lwjgl-platform', currentValue: '2.8.5' },
+        { depName: 'org.clojure:clojure', currentValue: '1.4.0' },
+        { depName: 'org.clojure:clojure', currentValue: '1.5.0' },
+        { depName: 'clj-stacktrace:clj-stacktrace', currentValue: '0.2.4' },
+        {
+          depName: 'clj-time:clj-time',
+          currentValue: '0.12.0',
+          depType: 'managed-dependencies',
+        },
+        {
+          depName: 'me.raynes:fs',
+          currentValue: '1.4.6',
+          depType: 'managed-dependencies',
+        },
+        {
+          depName: 'lein-pprint:lein-pprint',
+          currentValue: '1.1.1',
+          depType: 'plugins',
+        },
+        {
+          depName: 'lein-assoc:lein-assoc',
+          currentValue: '0.1.0',
+          depType: 'plugins',
+        },
+        {
+          depName: 's3-wagon-private:s3-wagon-private',
+          currentValue: '1.1.1',
+          depType: 'plugins',
+        },
+        {
+          depName: 'lein-foo:lein-foo',
+          currentValue: '0.0.1',
+          depType: 'plugins',
+        },
+        {
+          depName: 'lein-bar:lein-bar',
+          currentValue: '0.0.1',
+          depType: 'plugins',
+        },
+        {
+          depName: 'cider:cider-nrepl',
+          currentValue: '0.7.1',
+          depType: 'plugins',
+        },
+        {
+          depName: 'com.theoryinpractise:clojure-maven-plugin',
+          currentValue: '1.3.13',
+          depType: 'pom-plugins',
+        },
+        {
+          depName: 'org.apache.tomcat.maven:tomcat7-maven-plugin',
+          currentValue: '2.1',
+          depType: 'pom-plugins',
+        },
+        {
+          depName: 'com.google.appengine:appengine-maven-plugin',
+          currentValue: '1.9.68',
+          depType: 'pom-plugins',
+        },
+      ],
+    });
   });
   it('extractVariables', () => {
     expect(extractVariables('(def foo "1")')).toEqual({ foo: '1' });

diff --git a/lib/manager/maven/__snapshots__/extract.spec.ts.snap b/lib/manager/maven/__snapshots__/extract.spec.ts.snap
@@ -166,12 +166,3 @@ Object {
   "packageFile": null,
 }
 `;
-
-exports[`manager/maven/extract extractDependencies tries minimum manifests 1`] = `
-Object {
-  "datasource": "maven",
-  "deps": Array [],
-  "mavenProps": Object {},
-  "packageFile": null,
-}
-`;