Skip to content

Commit

Permalink
fix(gradle-lite): Always use Maven registry url (#8721)
Browse files Browse the repository at this point in the history
  • Loading branch information
zharinov committed Feb 16, 2021
1 parent 68f89c4 commit d92dc80
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 4 deletions.
5 changes: 4 additions & 1 deletion lib/manager/gradle-lite/extract.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,10 @@ describe('manager/gradle-lite/extract', () => {
{
depName: 'foo:bar',
currentValue: '1.2.3',
registryUrls: ['https://example.com'],
registryUrls: [
'https://repo.maven.apache.org/maven2',
'https://example.com',
],
},
],
},
Expand Down
10 changes: 7 additions & 3 deletions lib/manager/gradle-lite/extract.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as upath from 'upath';
import * as datasourceMaven from '../../datasource/maven';
import { id as datasource, defaultRegistryUrls } from '../../datasource/maven';
import { logger } from '../../logger';
import { readLocalFile } from '../../util/fs';
import { ExtractConfig, PackageDependency, PackageFile } from '../common';
Expand Down Expand Up @@ -39,7 +39,7 @@ export async function extractAllPackageFiles(
for (const packageFile of reorderFiles(packageFiles)) {
packageFilesByName[packageFile] = {
packageFile,
datasource: datasourceMaven.id,
datasource,
deps: [],
};

Expand Down Expand Up @@ -90,7 +90,11 @@ export async function extractAllPackageFiles(
const { deps } = pkgFile;
deps.push({
...dep,
registryUrls: [...(dep.registryUrls || []), ...registryUrls],
registryUrls: [
...defaultRegistryUrls,
...(dep.registryUrls || []),
...registryUrls,
],
});
packageFilesByName[key] = pkgFile;
});
Expand Down

0 comments on commit d92dc80

Please sign in to comment.