fix: remove unused binarySource=auto (#8461)

renovatebot · Feb 4, 2021 · df2a31c · df2a31c
1 parent 6ab2b02
commit df2a31c
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 4 deletions.
diff --git a/lib/config/__snapshots__/migration.spec.ts.snap b/lib/config/__snapshots__/migration.spec.ts.snap
@@ -84,6 +84,7 @@ Object {
   "baseBranches": Array [
     "next",
   ],
+  "binarySource": "global",
   "branchName": "{{{branchPrefix}}}{{{additionalBranchPrefix}}}{{{branchTopic}}}",
   "branchPrefix": "renovate/",
   "commitMessage": "{{#if semanticCommitType}}{{semanticCommitType}}{{#if semanticCommitScope}}({{semanticCommitScope}}){{/if}}: {{/if}}some commit message",

diff --git a/lib/config/definitions.ts b/lib/config/definitions.ts
@@ -281,11 +281,11 @@ const options: RenovateOptions[] = [
   {
     name: 'binarySource',
     description:
-      'Where to source binaries like `npm` and `yarn` from, choices are `auto`, `global` and `docker`.',
+      'Controls whether third party tools like npm or Gradle are called directly, or via Docker sidecar containers.',
     admin: true,
     type: 'string',
-    allowedValues: ['auto', 'global', 'docker'],
-    default: 'auto',
+    allowedValues: ['global', 'docker'],
+    default: 'global',
   },
   {
     name: 'redisUrl',

diff --git a/lib/config/migration.spec.ts b/lib/config/migration.spec.ts
@@ -39,6 +39,7 @@ describe('config/migration', () => {
         suppressNotifications: ['lockFileErrors', 'prEditNotification'],
         automerge: 'none' as never,
         automergeMajor: false,
+        binarySource: 'auto',
         automergeMinor: true,
         automergePatch: true,
         masterIssue: 'true',

diff --git a/lib/config/migration.ts b/lib/config/migration.ts
@@ -509,6 +509,8 @@ export function migrateConfig(
             migratedConfig.suppressNotifications || [];
           migratedConfig.suppressNotifications.push('deprecationWarningIssues');
         }
+      } else if (key === 'binarySource' && val === 'auto') {
+        migratedConfig.binarySource = 'global';
       }
     }
     if (migratedConfig.endpoints) {

diff --git a/lib/util/exec/common.ts b/lib/util/exec/common.ts
@@ -7,7 +7,6 @@ import { promisify } from 'util';
 export type Opt<T> = T | null | undefined;
 
 export enum BinarySource {
-  Auto = 'auto',
   Docker = 'docker',
   Global = 'global',
 }