fix(terraform): return early on parse errors and do not fail on check…

…list false positive (#19778)

Closes #19777

lib/modules/manager/terraform/extract.spec.ts

@@ -708,5 +708,16 @@ describe('modules/manager/terraform/extract', () => {
         },
       ]);
     });
+
+    it('return null if invalid HCL file', async () => {
+      const res = await extractPackageFile(
+        `
+          resource my provider
+        `,
+        'tfeWorkspace.tf',
+        {}
+      );
+      expect(res).toBeNull();
+    });
   });
 });

lib/modules/manager/terraform/extract.ts

@@ -1,3 +1,4 @@
+import is from '@sindresorhus/is';
 import { logger } from '../../../logger';
 import type { ExtractConfig, PackageFile } from '../types';
 import { resourceExtractors } from './extractors';
@@ -37,6 +38,10 @@ export async function extractPackageFile(
 
   const dependencies = [];
   const hclMap = hcl.parseHCL(content);
+  if (is.nullOrUndefined(hclMap)) {
+    logger.trace({ fileName }, 'failed to parse HCL file');
+    return null;
+  }
 
   const locks = await extractLocksForPackageFile(fileName);
 

lib/modules/manager/terraform/extractors/others/providers.spec.ts

@@ -0,0 +1,10 @@
+import { ProvidersExtractor } from './providers';
+
+describe('modules/manager/terraform/extractors/others/providers', () => {
+  const extractor = new ProvidersExtractor();
+
+  it('return null if no provider returned', () => {
+    const result = extractor.extract({}, []);
+    expect(result).toBeArrayOfSize(0);
+  });
+});

lib/modules/manager/terraform/extractors/others/providers.ts

@@ -9,7 +9,7 @@ export class ProvidersExtractor extends TerraformProviderExtractor {
   }
 
   extract(hclRoot: any, locks: ProviderLock[]): PackageDependency[] {
-    const providerTypes = hclRoot.provider;
+    const providerTypes = hclRoot?.provider;
     if (is.nullOrUndefined(providerTypes)) {
       return [];
     }