fix(manager/helmfile): Detect more local charts (#21093)

renovatebot · Mar 26, 2023 · e368cde · e368cde
1 parent 5110d43
commit e368cde
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 2 deletions.
diff --git a/lib/modules/manager/helmfile/__fixtures__/go-template.yaml b/lib/modules/manager/helmfile/__fixtures__/go-template.yaml
@@ -10,6 +10,12 @@ releases:
   - name: "{{ requiredEnv \"RELEASE_NAME\" }}"
     namespace: default
     chart: ./foo
+  - name: "{{ requiredEnv \"RELEASE_NAME\" }}"
+    namespace: default
+    chart: ../bar
+  - name: "{{ requiredEnv \"RELEASE_NAME\" }}"
+    namespace: default
+    chart: /baz
   - name: {{ requiredEnv "RELEASE_NAME" }}
     namespace: default
     chart: ./foo

diff --git a/lib/modules/manager/helmfile/extract.spec.ts b/lib/modules/manager/helmfile/extract.spec.ts
@@ -335,6 +335,14 @@ describe('modules/manager/helmfile/extract', () => {
       expect(result).toMatchObject({
         datasource: 'helm',
         deps: [
+          {
+            depName: '',
+            skipReason: 'local-chart',
+          },
+          {
+            depName: '',
+            skipReason: 'local-chart',
+          },
           {
             depName: '',
             skipReason: 'local-chart',

diff --git a/lib/modules/manager/helmfile/extract.ts b/lib/modules/manager/helmfile/extract.ts
@@ -59,8 +59,8 @@ export function extractPackageFile(
         };
       }
 
-      // If starts with ./ is for sure a local path
-      if (dep.chart.startsWith('./')) {
+      // If it starts with ./ ../ or / then it's a local path
+      if (['./', '../', '/'].some((val) => dep.chart.startsWith(val))) {
         return {
           depName: dep.name,
           skipReason: 'local-chart',