Skip to content

Commit

Permalink
chore(docs): add exceptions for force pushing a PR (#8623)
Browse files Browse the repository at this point in the history
  • Loading branch information
Chumper committed Feb 10, 2021
1 parent 9aa46fa commit f493359
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
8 changes: 7 additions & 1 deletion .github/contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,16 @@ Pull Requests can only be merged once all status checks are green, which means `

## Do not force push to your pull request branch

Please do not force push to your PR's branch after you have created your PR, as doing so makes it harder for us to review your work.
Please do not force push to your PR's branch after you have created your PR, as doing so forces us to review the whole PR again.
This makes it harder for us to review your work because we don't know what has changed.
PRs will always be squashed by us when we merge your work.
Commit as many times as you need in your pull request branch.

Force pushing a PR is OK when:

- you need to make large changes on a PR which require a full review anyway
- you need to bring the branch up-to-date with the default branch and incorporating the changes is more work than to create a new PR

## Re-requesting a review

Please do not ping your reviewer(s) by mentioning them in a new comment.
Expand Down
2 changes: 1 addition & 1 deletion .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,5 @@ I have verified these changes via:

<!-- Do you have any suggestions about this PR template? Edit it here: https://github.com/renovatebot/renovate/edit/master/.github/pull_request_template.md -->

<!-- Please do not force push to this PR's branch after you have created this PR, as doing so makes it harder for us to review your work. -->
<!-- Please do not force push to your PR's branch after you have created your PR, as doing so forces us to review the whole PR again. This makes it harder for us to review your work because we don't know what has changed. -->
<!-- PRs will always be squashed by us when we merge your work. Commit as many times as you need in this branch. -->

0 comments on commit f493359

Please sign in to comment.