Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve onboarding PR closed comment #22476

Merged
merged 2 commits into from
May 31, 2023
Merged

fix: improve onboarding PR closed comment #22476

merged 2 commits into from
May 31, 2023

Conversation

HonkingGoose
Copy link
Collaborator

Changes

  • Improve the onboarding PR closed comment
  • Use simple words and phrases
  • Put the "rename PR title and get fresh onboarding PR" method first

Context

Drive by PR, I'm not closing any issue with this.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@HonkingGoose HonkingGoose added the core:onboarding Related to the onboarding process label May 29, 2023
@HonkingGoose HonkingGoose marked this pull request as ready for review May 29, 2023 10:50
@viceice viceice requested a review from rarkins May 29, 2023 11:17
@rarkins rarkins added this pull request to the merge queue May 31, 2023
Merged via the queue into renovatebot:main with commit cdeaac8 May 31, 2023
11 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.105.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@HonkingGoose HonkingGoose deleted the fix/onboarding-pr-close-message branch May 31, 2023 15:19
@mugioka mugioka mentioned this pull request Jun 21, 2023
Merged
6 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rarkins rarkins rarkins approved these changes

Assignees
No one assigned
Labels
core:onboarding Related to the onboarding process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@HonkingGoose @renovate-release @rarkins