Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager/helmfile): use the specific helmfile version that specified in the helmfile.lock. #22904

Conversation

mugioka
Copy link
Contributor

@mugioka mugioka commented Jun 21, 2023

Changes

This feature is discussed here.

I updated the helmfile manager to use specific helmfile version that specified in the helmfile.lock when updating the helmfile.lock if tool constraints is not set manually.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@mugioka mugioka changed the title imprv/use specifc helmfile version that specified in helmfile lock imprv(manager/helmfile): use the specific helmfile version that specified in the helmfile.lock. Jun 21, 2023
@mugioka mugioka changed the title imprv(manager/helmfile): use the specific helmfile version that specified in the helmfile.lock. feat(manager/helmfile): use the specific helmfile version that specified in the helmfile.lock. Jun 21, 2023
@mugioka mugioka requested a review from viceice June 21, 2023 06:35
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

lib/modules/manager/helmfile/artifacts.ts Outdated Show resolved Hide resolved
@mugioka mugioka requested a review from viceice June 21, 2023 11:17
@viceice viceice requested a review from secustor June 21, 2023 11:19
@secustor secustor added this pull request to the merge queue Jun 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 21, 2023
@viceice viceice added this pull request to the merge queue Jun 21, 2023
Merged via the queue into renovatebot:main with commit 4cc21fa Jun 21, 2023
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.140.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mugioka mugioka deleted the imprv/use-specifc-helmfile-version-that-specified-in-helmfile-lock branch June 21, 2023 14:43
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants