Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typo in self-hosting example #22519

Merged
merged 1 commit into from
May 31, 2023

Conversation

ChristianCiach
Copy link
Contributor

The example demonstrates the usage of a config.json as a ConfigMap, but the explanation speaks of a config.js.

Since the example is actually using plain JSON, it makes sense to adapt the text instead of the example.

Changes

Fixes a small typo inside the self-hosted docs to be consistent with the shown example.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

The example demonstrates the usage of a `config.json` as a ConfigMap, but the explanation speaks of a `config.js`.

Since the example is actually using plain JSON, it makes sense to adapt the text instead of the example.
@ChristianCiach ChristianCiach changed the title Fix typo in self-hosting example docs: fix typo in self-hosting example May 31, 2023
@viceice viceice enabled auto-merge May 31, 2023 17:50
@viceice viceice added this pull request to the merge queue May 31, 2023
Merged via the queue into renovatebot:main with commit be760cb May 31, 2023
11 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.105.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants