Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement custom.<customMgrName> syntax for matchManagers #24112

Merged
merged 2 commits into from Aug 27, 2023
Merged

feat: implement custom.<customMgrName> syntax for matchManagers #24112

merged 2 commits into from Aug 27, 2023

Conversation

RahulGautamSingh
Copy link
Collaborator

Changes

  • Migrate and valiadate custom.<mgrName> string
  • Implement matching for custom managers with custom. prefix

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@RahulGautamSingh RahulGautamSingh mentioned this pull request Aug 27, 2023
Closed
@RahulGautamSingh RahulGautamSingh changed the title feat(package-rules/match-managers): implement custom.<customMgrName> syntax feat: implement custom.<customMgrName> syntax for matchManagers Aug 27, 2023
@secustor secustor added this pull request to the merge queue Aug 27, 2023
Merged via the queue into renovatebot:main with commit 9c322cd Aug 27, 2023
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 36.67.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@AlexandruLazarescu-TomTom AlexandruLazarescu-TomTom mentioned this pull request Aug 28, 2023
Merged
rarkins added a commit that referenced this pull request Aug 28, 2023
@rarkins
Revert "feat: implement custom.<customMgrName> syntax for `matchMan…
65d0c9e 
…agers` (#24112)"

This reverts commit 9c322cd.
rarkins added a commit that referenced this pull request Aug 28, 2023
@rarkins
fix: Revert "feat: implement custom.<customMgrName> syntax for `mat…
30359ac 
…chManagers` (#24112) (#24125)
@viceice viceice added the regression Issue about a regression bug, or the PR caused it label Aug 28, 2023
@RahulGautamSingh RahulGautamSingh mentioned this pull request Aug 31, 2023
Merged
6 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@secustor secustor secustor approved these changes

@viceice viceice Awaiting requested review from viceice

Assignees
No one assigned
Labels
regression Issue about a regression bug, or the PR caused it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@RahulGautamSingh @renovate-release @secustor @viceice