Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "feat: implement custom.<customMgrName> syntax for matchManagers (#24112) #24125

Merged
merged 1 commit into from Aug 28, 2023

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Aug 28, 2023

This reverts commit 9c322cd.

Changes

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins merged commit 30359ac into main Aug 28, 2023
36 checks passed
@rarkins rarkins deleted the revert-24112-match-mgrs-custom.-syntac branch August 28, 2023 15:42
@rarkins
Copy link
Collaborator Author

rarkins commented Aug 28, 2023

FYI @RahulGautamSingh

If you run pnpm start --dry-run=lookup containerbase/base with/without your code you can see the difference (all regex dependencies disabled vs not)

@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 36.68.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants