Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datasource): remove unnecessary PyPI changelog URL overrides #27725

Merged
merged 6 commits into from Mar 15, 2024

Conversation

intgr
Copy link
Contributor

@intgr intgr commented Mar 5, 2024

Changes

Removed changelog overrides for packages that already have changelog URL in upstream package metadata. Often upstream links are more up to date than these hardcoded ones.

Context

E.g. for Django:

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Removed packages that already have changelog URL in upstream package metadata. Often upstream links are more up to date than these hardcoded ones.

E.g. for Django:

* Renovate: https://github.com/django/django/tree/master/docs/releases
* Upstream: https://docs.djangoproject.com/en/5.0/releases/
rarkins
rarkins previously approved these changes Mar 5, 2024
@rarkins rarkins enabled auto-merge March 5, 2024 08:33
auto-merge was automatically disabled March 5, 2024 08:34

Head branch was pushed to by a user without write access

@rarkins rarkins enabled auto-merge March 5, 2024 08:36
@viceice viceice changed the title chore(datasource): remove unnecessary PyPI changelog URL overrides fix(datasource): remove unnecessary PyPI changelog URL overrides Mar 10, 2024
viceice
viceice previously approved these changes Mar 10, 2024
@viceice viceice disabled auto-merge March 10, 2024 16:54
@viceice
Copy link
Member

viceice commented Mar 10, 2024

more failed tests, see PR changes

@intgr

This comment was marked as outdated.

@intgr
Copy link
Contributor Author

intgr commented Mar 12, 2024

After merging with latest main branch the test was there. Should be fine now.

@rarkins rarkins enabled auto-merge March 12, 2024 12:04
@rarkins rarkins self-requested a review March 12, 2024 12:04
@rarkins rarkins added this pull request to the merge queue Mar 15, 2024
Merged via the queue into renovatebot:main with commit 42ee263 Mar 15, 2024
35 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.249.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants