Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datasource): remove unnecessary PyPI changelog URL overrides #27725

Merged
merged 6 commits into from Mar 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/modules/datasource/__snapshots__/metadata.spec.ts.snap
Expand Up @@ -34,7 +34,7 @@ exports[`modules/datasource/metadata Should handle failed parsing of sourceUrls

exports[`modules/datasource/metadata Should handle manualChangelogUrls 1`] = `
{
"changelogUrl": "https://github.com/django/django/tree/master/docs/releases",
"changelogUrl": "https://github.com/flyingcircusio/pycountry/blob/master/HISTORY.txt",
"releases": [
{
"releaseTimestamp": "2018-07-13T10:14:17.000Z",
Expand All @@ -53,7 +53,7 @@ exports[`modules/datasource/metadata Should handle manualChangelogUrls 1`] = `
"version": "2.2.0",
},
],
"sourceUrl": "https://github.com/django/django",
"sourceUrl": "https://github.com/flyingcircusio/pycountry",
}
`;

Expand Down
9 changes: 0 additions & 9 deletions lib/modules/datasource/metadata-manual.ts
Expand Up @@ -17,17 +17,11 @@ export const manualChangelogUrls: Record<string, Record<string, string>> = {
'https://github.com/angular/angular/blob/master/packages/zone.js/CHANGELOG.md',
},
pypi: {
alembic: 'https://alembic.sqlalchemy.org/en/latest/changelog.html',
beautifulsoup4:
'https://bazaar.launchpad.net/~leonardr/beautifulsoup/bs4/view/head:/CHANGELOG',
django: 'https://github.com/django/django/tree/master/docs/releases',
djangorestframework:
'https://www.django-rest-framework.org/community/release-notes/',
flake8: 'https://flake8.pycqa.org/en/latest/release-notes/index.html',
'django-storages':
'https://github.com/jschneier/django-storages/blob/master/CHANGELOG.rst',
hypothesis:
'https://github.com/HypothesisWorks/hypothesis/blob/master/hypothesis-python/docs/changes.rst',
lxml: 'https://git.launchpad.net/lxml/plain/CHANGES.txt',
mypy: 'https://mypy-lang.blogspot.com/',
phonenumbers:
Expand All @@ -38,12 +32,9 @@ export const manualChangelogUrls: Record<string, Record<string, string>> = {
'https://github.com/flyingcircusio/pycountry/blob/master/HISTORY.txt',
'django-debug-toolbar':
'https://django-debug-toolbar.readthedocs.io/en/latest/changes.html',
'firebase-admin':
'https://firebase.google.com/support/release-notes/admin/python',
requests: 'https://github.com/psf/requests/blob/master/HISTORY.md',
sqlalchemy: 'https://docs.sqlalchemy.org/en/latest/changelog/',
uwsgi: 'https://uwsgi-docs.readthedocs.io/en/latest/#release-notes',
wagtail: 'https://github.com/wagtail/wagtail/tree/master/docs/releases',
},
docker: {
'gitlab/gitlab-ce':
Expand Down
10 changes: 5 additions & 5 deletions lib/modules/datasource/metadata.spec.ts
Expand Up @@ -27,12 +27,12 @@ describe('modules/datasource/metadata', () => {
};

const datasource = PypiDatasource.id;
const packageName = 'django';
const packageName = 'pycountry';

addMetaData(dep, datasource, packageName);
expect(dep).toMatchSnapshot({
changelogUrl:
'https://github.com/django/django/tree/master/docs/releases',
'https://github.com/flyingcircusio/pycountry/blob/master/HISTORY.txt',
});
});

Expand Down Expand Up @@ -512,13 +512,13 @@ describe('modules/datasource/metadata', () => {
const dep = partial<ReleaseResult>({});

const datasource = PypiDatasource.id;
const packageName = 'django';
const packageName = 'pycountry';

addMetaData(dep, datasource, packageName);
expect(dep).toEqual({
changelogUrl:
'https://github.com/django/django/tree/master/docs/releases',
sourceUrl: 'https://github.com/django/django',
'https://github.com/flyingcircusio/pycountry/blob/master/HISTORY.txt',
sourceUrl: 'https://github.com/flyingcircusio/pycountry',
});
});

Expand Down