Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): add exceptions for force pushing a PR #8623

Merged
merged 4 commits into from
Feb 10, 2021

Conversation

Chumper
Copy link
Contributor

@Chumper Chumper commented Feb 10, 2021

Changes:

Makes clear why force pushing a PR is discouraged and when it is OK to do so.

Context:

I created a new PR instead of force pushing the old one, because I took the documentation too literally

Documentation

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work

I have verified these changes via:

  • Documentation update only, or
  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

viceice
viceice previously approved these changes Feb 10, 2021
rarkins
rarkins previously approved these changes Feb 10, 2021
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small fixes needed, otherwise looks good to me.

.github/contributing.md Outdated Show resolved Hide resolved
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@rarkins rarkins dismissed stale reviews from viceice and themself via 0740f94 February 10, 2021 12:27
@rarkins rarkins merged commit f493359 into renovatebot:master Feb 10, 2021
@Chumper Chumper deleted the patch-1 branch February 10, 2021 13:02
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 24.44.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants