Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: move automerge deep dive to key concept section #11490

Merged

Conversation

HonkingGoose
Copy link
Collaborator

@HonkingGoose HonkingGoose commented Aug 30, 2021

Changes:

  • Move existing automerge deep dive to key-concepts

Context:

Step one of making a key concepts page for the automerge feature.

I think the text needs some more work to make it beginner friendly.
Do you want me to make changes in this PR, or do we first want to move the document to its new place?

Helps with #11237, but does not close it.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins
Copy link
Collaborator

rarkins commented Aug 31, 2021

Let's rename it to automerge.md

@HonkingGoose
Copy link
Collaborator Author

Let's rename it to automerge.md

Done! 😄

Do you want me to make some changes that I think are good right now, or do you first want to put the file in the correct place and fixup the sidebar on the publishing repository?

@HonkingGoose HonkingGoose marked this pull request as ready for review August 31, 2021 09:01
@HonkingGoose
Copy link
Collaborator Author

Do you want me to make some changes that I think are good right now, or do you first want to put the file in the correct place and fixup the sidebar on the publishing repository?

@rarkins I saw that you approved the PR, so I guess you're happy with the file as-is? The PR is still waiting to be merged though. Can you explain what you'd like me to do?

@rarkins rarkins merged commit 28793a3 into renovatebot:main Sep 1, 2021
@HonkingGoose HonkingGoose deleted the docs/key-concepts/automerge.md branch September 1, 2021 10:37
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 26.15.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@HonkingGoose HonkingGoose mentioned this pull request Sep 8, 2021
6 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants