feat: create datasource for artifactory registry #11602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jjcaballero
changed the title
…instead of an error
jjcaballero
force-pushed
the
feat/11474-artifactory-datasource
branch
from
745017f
to
5c580e5
Compare
rarkins
requested changes
Sep 7, 2021
viceice
requested changes
Sep 7, 2021
viceice
reviewed
Sep 8, 2021
viceice
reviewed
Sep 8, 2021
rarkins
previously approved these changes
Sep 11, 2021
|
@viceice I hate to ping you but it seems the pr is in on-hold waiting for your review but I see you already marked all your comments as resolved. I am afraid that GitHub is missing that. On the contrary, if the waiting is legitime because you would like to review something, it is totally fine. |
viceice
reviewed
Sep 16, 2021
viceice
reviewed
Sep 16, 2021
viceice
reviewed
Sep 16, 2021
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
|
@jjcaballero Please don't comment with done / resolved / ... That makes a lot of noise. Simpüly resolve discussions when done and re-request review. Wich should normally happen on same day. sometimes we are very busy, so a review needs a couple of days. |
viceice
reviewed
Sep 17, 2021
|
@viceice, any chance to have this merged/reviewed next week? Thanks |
viceice
reviewed
Sep 30, 2021
viceice
approved these changes
Sep 30, 2021
rarkins
changed the title
|
🎉 This PR is included in version 27.25.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Added artifactory datasource as described in #11474
Context:
Closes #11474
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: