fix(versioning/poetry): improve poetry prerelease version handling #11733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Poetry accepts a union of SemVer and PEP440, normalizing certain prerelease tags like alpha -> a, preview -> rc in its internal representation. Since packages published to PyPI use PEP440 versions, this means that a version requirement "^0.8.0-alpha.1" should be updated to "^0.8.0-alpha.2" under the `replace` rule when a version "0.8.0a2" is published to PyPI. To accomplish this, update the poetry versioning scheme to explicitly parse versions using the same regex and normalization rules as poetry itself, and reemit them in SemVer format before kicking down to the npm versioning scheme. The normalization is applied in reverse before returning.
jvansanten
changed the title
jvansanten
changed the title
jvansanten
changed the title
viceice
changed the title
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
HonkingGoose
suggested changes
Sep 14, 2021
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
HonkingGoose
suggested changes
Sep 15, 2021
viceice
changed the title
viceice
reviewed
Sep 15, 2021
HonkingGoose
previously approved these changes
Sep 15, 2021
|
@jvansanten I just saw this PR. What a great first-time contribution! |
Thanks! I just fixed up a few extra nits reported by codecov and type-check. |
Older releases of matplotlib (e.g. 0.98.5.1) use PEP440-style release segments of arbitary length. There is no clean mapping from the post-patch segments to SemVer, but this style seems fairly rare and safe to ignore.
|
I think we're hitting a merge conflict because the tests now use the Jest table format due to PR: #11931 |
This reverts commit b585c54 (due to overeager use of `yarn version` for a local deployment)
Ugh, okay, will fix up. |
|
Looks like it needs coverage |
rarkins
requested changes
Oct 22, 2021
rarkins
previously approved these changes
Oct 22, 2021
viceice
approved these changes
Oct 22, 2021
|
🎉 This PR is included in version 28.8.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Update the poetry versioning scheme to explicitly parse versions using the same regex and normalization rules as poetry itself, and reemit them in SemVer format before kicking down to the npm versioning scheme. The normalization is applied in reverse before returning.
Context:
Poetry accepts a union of SemVer and PEP440, normalizing certain prerelease tags like alpha -> a, preview -> rc in its internal representation. Since packages published to PyPI use PEP440 versions, this means that a version requirement "^0.8.0-alpha.1" should be updated to "^0.8.0-alpha.2" under the
replacerule when a version "0.8.0a2" is published to PyPI. In the previous implementation, PEP440-named releases were simply filtered out.See also:
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: