fix: lowercase first word of commit message

[RahulGautamSingh]

Changes:

Updated code so that only first word of commit messages and prTitle is lowercased instead of the whole message.

Context:

Closes #12062

Documentation (please check one with an [x])

• I have updated the documentation, or
• No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

• Code inspection only, or
• Newly added/modified unit tests, or
• No unit tests but ran on a real repository, or
• Both unit tests + ran on a real repository

[rarkins]

Needs more tests added. I think you'll find it doesn't work as expected. e.g. we should test:

fix: Upgrade something, fix(docs): Something else, Really great feature: Foo, etc.

[rarkins]

I'm not sure this is accurate enough

[viceice]

I think this should be done in commit message builder.

[RahulGautamSingh]

str = str.replace(
        str.includes(':') ? /.*: \w+/ : /^\w+/,
        (match) => match.toLowerCase()
      );

This snippet works fine for the all the cases except Really great feature: Foo, for this type of message it lowercases the whole string which is a problem. Isn't such a commit message valid, cause it violates the good-commit-message rules?

Regarding the accuracy of the regex, we are only targeting the sub-string we want to lowercase

1. /.*: \w/ -> It will look for a semi-colon and a word after it (i.e first word of message)
   -Eg. fix: Upgrade something for this our match is fix: Upgrade
2. /^\w/ -> It matches first word of the message.
   -Eg. Upgrade Something Please -> It matches Upgrade.

Also I was wondering what would be the updated commit message for Really great feature: Foo

1. really great feature: Foo or,
2. really great feature: foo

[viceice]

i still suggest to move the whole logic to this file:

https://github.com/renovatebot/renovate/blob/5af1b77f6919b554b3170c2465094a1442eb0221/lib/workers/repository/model/commit-message.ts#L1-L55

As we build the message there, so it should be more easily to fix it there for all

[RahulGautamSingh]

@viceice I am not sure where the changes need to be updated in the new file, could you please guide me by commenting on the file where the certain functionalities needs to be added.

[pret-a-porter]

@RahulGautamSingh I guess in general would be nice if BranchUpgradeConfig interface will have instance of CommitMessage class. Therefore need to refactor lib/workers/repository/updates/generate.ts to using this class. During this refactoring maybe will be required extend functionality of CommitMessage or create inherited class for specific purposes.

[RahulGautamSingh]

Thanks for the help @pret-a-porter . Seems that I need to go through the code and refactor it. I am closing this PR for now and will create a new one when I have updated the code.

Hey @rarkins ,once you give the above suggestion by @pret-a-porter a 👍 I will start my work.