Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workers/global): check git at startup #12935

Merged
merged 9 commits into from Dec 8, 2021
Merged

feat(workers/global): check git at startup #12935

merged 9 commits into from Dec 8, 2021

Conversation

olegkrivtsov
Copy link
Contributor

Changes:

Check Git version at startup #11167. It requires testing on Windows CI as discussed previously.

Context:

Closes #11167

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice added the ci:fulltest Run full test suite on all platforms label Dec 3, 2021
lib/util/git/index.ts Outdated Show resolved Hide resolved
@rarkins rarkins requested a review from viceice December 3, 2021 09:57
@rarkins rarkins requested a review from viceice December 8, 2021 10:21
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small thing

lib/workers/global/initialize.spec.ts Outdated Show resolved Hide resolved
lib/workers/global/initialize.spec.ts Outdated Show resolved Hide resolved
lib/workers/global/initialize.spec.ts Outdated Show resolved Hide resolved
@rarkins rarkins merged commit 3fa21fb into renovatebot:main Dec 8, 2021
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 29.35.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@bytestream
Copy link
Contributor

What specifically in git 2.33.0 is required? It's not available in Debian stable repositories https://packages.debian.org/bullseye/git

@rarkins
Copy link
Collaborator

rarkins commented Dec 9, 2021

Blobless clone filtering and improvements to enable sparse checkout. This requirement cannot be relaxed and has previously been documented, but now it's finally detected at startup

@HansAarneLiblik
Copy link

Do you prefer anyone that uses renovate on debian image to use some unstable / testing versions of the image or compile git themselves ?
Perhaps this check can be disabled in self-hosted environments?

@rarkins
Copy link
Collaborator

rarkins commented Dec 9, 2021

Do you prefer anyone that uses renovate on debian image to use some unstable / testing versions of the image or compile git themselves ?

Compile git yourselves, or run it as a Docker image instead. Renovate heavily uses git, and will continue to utilize quite recent versions going forward, and this is therefore a requirement of using Renovate.

Perhaps this check can be disabled in self-hosted environments?

No, because we need functionality from the minimum version of git specified. Without it, people will sometimes get weird errors and waste both their time and ours trying to work out why.

@evanrich
Copy link

evanrich commented Dec 9, 2021

This fails in node:17 image based on bullseye, and an apt update/upgrade shows the latest git version is installed. short of now producing your own images, you cannot go further until the git binary has been updated.

bullseye: https://packages.debian.org/bullseye/git

@viceice
Copy link
Member

viceice commented Dec 9, 2021

Use renovate/node image.

Please use GitHub discussion for further messages.

#13026 (reply in thread)

@rarkins
Copy link
Collaborator

rarkins commented Dec 9, 2021

git 2.33.0 has been a documented requirement since 27.0.0

@renovatebot renovatebot locked as resolved and limited conversation to collaborators Dec 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ci:fulltest Run full test suite on all platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check git at startup
7 participants