Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docker): Revert "fix(docker): use a HEAD request to the real resource auth." #15018

Merged
merged 2 commits into from
Apr 8, 2022
Merged

fix(docker): Revert "fix(docker): use a HEAD request to the real resource auth." #15018

merged 2 commits into from
Apr 8, 2022

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Apr 8, 2022

Reverts #14744

viceice
viceice approved these changes Apr 8, 2022
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to check how the cli would do this, as it seems we make something wrong.

/cc @vlagorce

@viceice
Copy link
Member

viceice commented Apr 8, 2022

needs reopen #14708 after merge

@rarkins rarkins changed the title fix: Revert "fix(docker): use a HEAD request to the real resource auth." fix(docker): Revert "fix(docker): use a HEAD request to the real resource auth." Apr 8, 2022
@rarkins rarkins enabled auto-merge (squash) April 8, 2022 08:45
@vlagorce
Copy link
Contributor

vlagorce commented Apr 8, 2022 •
edited

I dig quickly on docker-cli
https://github.com/docker/cli/blob/master/cli/trust/trust.go#L139

I guess we should have stick to the GET.

Parsing the scope remains something to do anyway rather than assuming pull is expected. As well as using the right resources and not only v2.

@rarkins rarkins merged commit 6cadcdd into main Apr 8, 2022
@rarkins rarkins deleted the revert-14744-acr_metadata-read branch April 8, 2022 11:28
@viceice viceice mentioned this pull request Apr 8, 2022
Closed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rarkins @viceice @vlagorce @renovate-release