feat(config/migration): migrate config with a PR #15122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example PR ladzaretti/feat-config-migration#1. |
rarkins
requested changes
Apr 15, 2022
There was a problem hiding this comment.
- Currently this code is too "scattered" across many files. We should try to isolate it into as few locations as possible
- Please look into whether it can be delayed and done as part of repository finalization
- I don't think we need to make this a globalOnly solution like onboarding as this would mean nobody in the hosted app can turn it on or off individually
moved to finilize repo
1 + 2. now we have a single execution entry point at |
migrated-config-data.ts modifications
drop globalOnly setting for config migration
files excluded from null check
viceice
requested changes
Apr 17, 2022
lib/workers/repository/config-migration/branch/migrated-config-data.ts
Outdated
Show resolved
Hide resolved
- removed some unnecessary config flags - migrated from using model/commit-message for now being - moved gitAuthor near commitAndPush - migrated-config-data is now a static factory class now using handlebars for prbody
- strict null check fixes
viceice
requested changes
Apr 18, 2022
lib/workers/repository/config-migration/branch/migrated-data.ts
Outdated
Show resolved
Hide resolved
lib/workers/repository/config-migration/branch/migrated-data.ts
Outdated
Show resolved
Hide resolved
lib/workers/repository/config-migration/branch/migrated-data.ts
Outdated
Show resolved
Hide resolved
- added unit tests for branch/create + commit-message
- CR changes
- removed configMigrationBranch from RenovateConfig - revert onboardingPrTitle (globalOnly = true) - revert pruneStaleBranches - added config-migration/common.ts to hold migration branch name
- added unit tests for branch/rebase
- added unit tests for branch/migrated-data
- updated unit tests for branch/migrated-data
- added unit tests for branch/index
- added unit tests for pr/error-warnings - added unit tests for pr/index
- fixed replaceAll
- added a configMigration entry in configuration-options.md
- create.spec.ts: cover untaken branch
HonkingGoose
suggested changes
Apr 20, 2022
lib/workers/repository/config-migration/pr/errors-warnings.spec.ts
Outdated
Show resolved
Hide resolved
lib/workers/repository/config-migration/pr/errors-warnings.spec.ts
Outdated
Show resolved
Hide resolved
…aretti/renovate into feat-config-migrate
Gabriel-Ladzaretti
force-pushed
the
feat-config-migrate
branch
from
b988058
to
d2bd864
Compare
viceice
reviewed
May 25, 2022
- move spy to module scope
- update 422 pr catch block
|
Updated the |
|
Anything else to do here :? |
viceice
reviewed
Jun 9, 2022
- remove unnecessary default branch check
viceice
reviewed
Jun 13, 2022
viceice
approved these changes
Jun 13, 2022
rarkins
approved these changes
Jun 18, 2022
|
🎉 This PR is included in version 32.90.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Create a PR when config migration is needed, similarly to the way onboarding PR are made.
Context
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: