fix(docker): use a GET request to the real resource auth. (#14744) #15312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlagorce
force-pushed
the
14708_resource_scope_action
branch
2 times, most recently
from
07c1ee9
to
9ed6d20
Compare
|
please add all relevant issues / PRs to context section |
JamieMagee
reviewed
Apr 27, 2022
|
Which container registries did you test against? |
I have tested against Azure Container Registry. |
viceice
reviewed
Apr 29, 2022
viceice
changed the title
viceice
approved these changes
May 19, 2022
|
🎉 This PR is included in version 32.64.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Some docker registries needs a specific scope when listing available tags.
This change aims to pass the registry url to the "auth" method in order to retrieve the right scope.
Context
Closes #14708
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: