-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(changelog): gitRef check #15869
fix(changelog): gitRef check #15869
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please validate that it works for gitlab too
90485b5
to
a2e7938
Compare
84b8c0e
to
2cbccf1
Compare
For some reason, #15653 along with this PR seems to break
|
Found the reason, fix is ready |
Thanks, I think I found another way of doing this thing but also using |
2cbccf1
to
b365fd7
Compare
a1d990b
to
b018a64
Compare
Already rebased from main, fixed tests, added a new test for |
lib/workers/repository/update/pr/changelog/release-notes.spec.ts
Outdated
Show resolved
Hide resolved
CLA check hung 😞 |
🎉 This PR is included in version 32.79.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes
For some dependencies, (in my case
kubernetes/autoscaler
), they don't have aChangelog.md
and the releases are mixed inside the repo:I'm using this datasource configuration:
And I'm receiving this
res
variable when trying to get the Changelog:As you can see,
version
tag is different fromgitRef
and this comparison won't ever match for this use-case:We need to check also if matches the
gitRef
so that it can download the Changelog from releases notes.Context
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: