-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add Article on how Swissquote uses Renovate #16809
Conversation
Hi @HonkingGoose as discussed in #16502 here is my PR for my Medium article |
This comment was marked as resolved.
This comment was marked as resolved.
Sure, it's done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial review, mainly focusing on:
- One sentence per line
- Typos
- Capitalization
- Other small stuff
Edit: Please "batch" all my suggestions into one commit, instead of applying them one-by-one.
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
I fixed a few more punctuation issues, should I also make one sentence per line for list items ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more things.
Thank you for fixing some more punctuation problems. 😉 Keep the lists as they are, or we'll have problems with the display of the lists. 😉 |
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
I think that using two spaces at the start of a line adds the line to the previous list item instead of starting a new one or ending the list |
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice read!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can keep the good part "It's not only about the tooling" and drop the mention of Dependabot and Snyk:
- Remove line which mentions Dependabot and Snyk
- Copy/paste good part into the next sentence
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nearly there! 😄
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small things to fix, and then we're good to merge for real. I don't think there's any point in me reviewing it over and over. It's time to get merging soon! 😄
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm done reviewing this. 😉 I think this is good to merge now. 🥳
awesome, thanks a lot for all the proposed improvements @HonkingGoose |
@onigoetz Feel free to take my improvements and put them in your article on Medium. 😉 |
We can ignore the coverage false positive. @HonkingGoose do you think we should add links into this article as part of this PR, or afterwards? |
Let's do it afterwards. I don't want to hold up this PR any longer. I'll create a new issue to track this work. |
🎉 This PR is included in version 32.158.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes
As discussed in #16502 and #16484 this PR proposes my Medium Article about Renovate in a new User Stories section.
Context
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: