Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add azure pipelines built-in tasks version data #16949

Merged
merged 15 commits into from
Aug 8, 2022

Conversation

JamieMagee
Copy link
Contributor

@JamieMagee JamieMagee commented Aug 3, 2022

Changes

Adds version information for Azure Pipelines built-in tasks.

There is no public API that exposes this information. I checked with the team that maintains these tasks, and parsing the git history was the recommended way to extract version information. I don't believe doing this during a Renovate run is feasible, hence adding it as static information in the repository.

The script currently catches 3 2 exceptions throughout the azure-pipelines-tasks repository's history:

  • Failed to parse Tasks/CondaEnvironmentV0/task.json at 7ff8f87757903515cdcf521a76f92626bd06ab2a
    • CondaEnvironmentV0/task.json was moved to CondaEnvironmentV1/task.json
  • Failed to parse Tasks/DownloadPipelineArtifactV2/task.json at d0c0a1cce48931d8ba009ef3db51651c47b0c924
    • Someone added a comment to DownloadPipelineArtifactV2/task.json
  • Failed to parse Tasks/IISWebAppDeployment/task.json at 05114960d2286a029cf1cbd99380df3a8332e9be
    • The file was deleted (and later re-added)

If there are any git wizards who know how to exclude renames and deletions from git rev-list please let me know.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@JamieMagee JamieMagee force-pushed the feat/azure-pipelines-tasks-generate branch from 405e9b0 to 4eb8536 Compare August 3, 2022 22:19
@JamieMagee JamieMagee requested a review from viceice August 4, 2022 05:40
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this algorithm you created needs some documentation to explain the "why", in case someone else needs to maintain it :)

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

tools/azure-pipelines-tasks-json-generate.mjs Show resolved Hide resolved
viceice
viceice previously approved these changes Aug 5, 2022
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering that it seems quite slow, how/when will this command need to be called?

@JamieMagee
Copy link
Contributor Author

I think once a week should cover it. Shall I create a follow-up task to write a weekly scheduled GitHub Actions workflow?

@rarkins
Copy link
Collaborator

rarkins commented Aug 8, 2022

Yeah, that would be good. I just wanted to make sure it doesn't run as part of yarn test or any time like that. If it's only manually invoked then that's fine by me

@JamieMagee
Copy link
Contributor Author

This PR adds the script, but doesn't run it anywhere. It requires a manual run, same as the update:distro-info script we have to update Debian and Ubuntu version information.

@viceice
Copy link
Member

viceice commented Aug 8, 2022

I think once a week should cover it. Shall I create a follow-up task to write a weekly scheduled GitHub Actions workflow?

sounds good, like that. how should it notify us of changes? ideally with an update PR. 🤗

@JamieMagee
Copy link
Contributor Author

sounds good, like that. how should it notify us of changes? ideally with an update PR. 🤗

I created #17050

@JamieMagee JamieMagee merged commit 5502afa into main Aug 8, 2022
@JamieMagee JamieMagee deleted the feat/azure-pipelines-tasks-generate branch August 8, 2022 22:01
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 32.153.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants