feat(release notes): be able to fetch release notes from Azure DevOps #19136
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Co-authored-by: Rhys Arkins <rhys@arkins.net>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
sch1ldkr0ete
requested review from
rarkins
and removed request for
JamieMagee
| export type ChangeLogError = | ||
| | 'MissingGithubToken' | ||
| | 'MissingGitlabToken' | ||
| | 'MissingAzureToken'; |
There was a problem hiding this comment.
@rarkins I think we can join to single MissingToken error ?
| { | ||
| version: '4.33.0', | ||
| gitRef: '4.33.0', | ||
| } as ChangeLogRelease |
There was a problem hiding this comment.
| } as ChangeLogRelease | |
| } satisfies ChangeLogRelease |
| { | ||
| version: '4.33.0', | ||
| gitRef: '4.33.0', | ||
| } as ChangeLogRelease |
There was a problem hiding this comment.
| } as ChangeLogRelease | |
| } satisfies ChangeLogRelease |
| } as ChangeLogRelease | ||
| ); | ||
|
|
||
| expect(res).toMatchSnapshot({ |
There was a problem hiding this comment.
| expect(res).toMatchSnapshot({ | |
| expect(res).toMatchObject({ |
| await getChangeLogJSON({ | ||
| ...upgrade, | ||
| }) | ||
| ).toMatchSnapshot({ |
There was a problem hiding this comment.
| ).toMatchSnapshot({ | |
| ).toMatchObject({ |
| await getChangeLogJSON({ | ||
| ...upgrade, | ||
| }) | ||
| ).toMatchSnapshot({ |
There was a problem hiding this comment.
| ).toMatchSnapshot({ | |
| ).toMatchObject({ |
| import { ensureTrailingSlash } from '../../../../../../util/url'; | ||
| import type { ChangeLogFile } from '../types'; | ||
|
|
||
| export const id = 'azure-changelog'; |
| const url = `${ensureTrailingSlash( | ||
| endpoint | ||
| )}git/repositories/${urlEncodedRepo}/refs?filter=tags&$top=100&api-version=7.0`; |
There was a problem hiding this comment.
use joinUrlParts helper to concat url parts
| ); | ||
| } | ||
|
|
||
| return tags.map((tag) => tag.name).filter(Boolean); |
There was a problem hiding this comment.
| return tags.map((tag) => tag.name).filter(Boolean); | |
| return tags.map((tag) => tag.name).filter(is.string); |
|
Please read our devel best practices renovate/docs/development/best-practices.md Lines 1 to 2 in ca66ada |
This comment was marked as spam.
This comment was marked as spam.
|
@sch1ldkr0ete @viceice Hi! Is there some way we can progress this and get it merged? It is a really important change for our organization since we deploy a lot of internal packages via Azure private feeds. |
|
🤷♂️ it's not marked to be reviewed again. we don't monitor for changes. so the author needs to use the GitHub request review feature. @sorensenmatias feel free to open a new PR with the requested changes to continue. |
|
Sorry! This got out of my focus. I will process the requested changes this week. |
|
That would be fantastic! Thank you. |
|
@sch1ldkr0ete - these may be of interest. I recently refactored the changelog module #23076 in preparation for adding new changelog sources, eg: Bitbucket Cloud #22094 |
|
@sch1ldkr0ete I noticed that this PR seems to still have some review comments from @viceice Do you expect to have time to resume work on the PR? |
|
Closing due to inactivity, PR would be welcome again |
Changes
Add support for fetching release notes from Azure DevOps. (Just for markdown saved in the source repo, release lists are pretty special in Azure DevOps.)
Context
Closes #18324
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: