refactor: MergeConfidence types

lib/util/merge-confidence/common.ts

@@ -0,0 +1,6 @@
+export const MERGE_CONFIDENCE = [
+  'low',
+  'neutral',
+  'high',
+  'very high',
+] as const;

lib/util/merge-confidence/index.spec.ts

@@ -1,6 +1,7 @@
 import * as httpMock from '../../../test/http-mock';
 import * as memCache from '../cache/memory';
 import * as hostRules from '../host-rules';
+import type { MergeConfidence } from './types';
 import {
   getMergeConfidenceLevel,
   isActiveConfidenceLevel,
@@ -18,7 +19,9 @@ describe('util/merge-confidence/index', () => {
     });
 
     it('returns false if nonsense', () => {
-      expect(isActiveConfidenceLevel('nonsense')).toBeFalse();
+      expect(
+        isActiveConfidenceLevel('nonsense' as MergeConfidence)
+      ).toBeFalse();
     });
 
     it('returns true if valid value (high)', () => {

lib/util/merge-confidence/index.ts

@@ -4,21 +4,19 @@ import * as memCache from '../cache/memory';
 import * as packageCache from '../cache/package';
 import * as hostRules from '../host-rules';
 import { Http } from '../http';
+import { MERGE_CONFIDENCE } from './common';
+import type { MergeConfidence } from './types';
 
 const http = new Http('merge-confidence');
 
-const MERGE_CONFIDENCE = ['low', 'neutral', 'high', 'very high'];
-type MergeConfidenceTuple = typeof MERGE_CONFIDENCE;
-export type MergeConfidence = MergeConfidenceTuple[number];
-
 export const confidenceLevels: Record<MergeConfidence, number> = {
   low: -1,
   neutral: 0,
   high: 1,
   'very high': 2,
 };
 
-export function isActiveConfidenceLevel(confidence: string): boolean {
+export function isActiveConfidenceLevel(confidence: MergeConfidence): boolean {
   return confidence !== 'low' && MERGE_CONFIDENCE.includes(confidence);
 }
 
@@ -76,7 +74,7 @@ export async function getMergeConfidenceLevel(
   if (cachedResult) {
     return cachedResult;
   }
-  let confidence = 'neutral';
+  let confidence: MergeConfidence = 'neutral';
   try {
     const res = (await http.getJson<{ confidence: MergeConfidence }>(url)).body;
     if (MERGE_CONFIDENCE.includes(res.confidence)) {

lib/util/merge-confidence/types.ts

@@ -0,0 +1,3 @@
+import type { MERGE_CONFIDENCE } from './common';
+
+export type MergeConfidence = (typeof MERGE_CONFIDENCE)[number];

lib/workers/repository/process/lookup/types.ts

@@ -8,6 +8,7 @@ import type {
   RangeConfig,
 } from '../../../../modules/manager/types';
 import type { SkipReason } from '../../../../types';
+import type { MergeConfidence } from '../../../../util/merge-confidence/types';
 
 export interface FilterConfig {
   allowedVersions?: string;
@@ -43,7 +44,7 @@ export interface LookupUpdateConfig
   separateMultipleMajor?: boolean;
   datasource: string;
   packageName: string;
-  minimumConfidence?: string;
+  minimumConfidence?: MergeConfidence | undefined;
   replacementName?: string;
   replacementVersion?: string;
 }

lib/workers/repository/update/branch/status-checks.ts

@@ -2,10 +2,8 @@ import type { RenovateConfig } from '../../../../config/types';
 import { logger } from '../../../../logger';
 import { platform } from '../../../../modules/platform';
 import type { BranchStatus } from '../../../../types';
-import {
-  MergeConfidence,
-  isActiveConfidenceLevel,
-} from '../../../../util/merge-confidence';
+import { isActiveConfidenceLevel } from '../../../../util/merge-confidence';
+import type { MergeConfidence } from '../../../../util/merge-confidence/types';
 
 export async function resolveBranchStatus(
   branchName: string,
@@ -80,7 +78,7 @@ export async function setStability(config: StabilityConfig): Promise<void> {
 
 export interface ConfidenceConfig extends RenovateConfig {
   confidenceStatus?: BranchStatus;
-  minimumConfidence?: MergeConfidence;
+  minimumConfidence?: MergeConfidence | undefined;
 }
 
 export async function setConfidence(config: ConfidenceConfig): Promise<void> {

lib/workers/types.ts

@@ -16,7 +16,7 @@ import type {
 } from '../modules/manager/types';
 import type { PlatformPrOptions } from '../modules/platform/types';
 import type { FileChange } from '../util/git/types';
-import type { MergeConfidence } from '../util/merge-confidence';
+import type { MergeConfidence } from '../util/merge-confidence/types';
 import type {
   ChangeLogRelease,
   ChangeLogResult,
@@ -61,7 +61,7 @@ export interface BranchUpgradeConfig
   releases?: ReleaseWithNotes[];
   releaseTimestamp?: string;
   repoName?: string;
-  minimumConfidence?: MergeConfidence;
+  minimumConfidence?: MergeConfidence | undefined;
   sourceDirectory?: string;
 
   updatedPackageFiles?: FileChange[];